tags:

views:

46

answers:

3
+1  Q: 

Am i doing this iteration right in javascript?

Consider the two implementations below,

data.addRows([
  ['2004', 1000],
  ['2005', 1170],
  ['2006', 660],
  ['2007', 1030]
]);

The above works (ie) it gets me what i want.

and my implementation is,

 for (var i = 0; i < 10; i++) {
        data.addRows['row'+i,i];
    }

Is this a valid for loop or what am i doing wrong?

I am using google visualization api for drawing charts but the answers below doesn't work out,

http://jsbin.com/okafa3/edit which is a copy of http://code.google.com/apis/visualization/documentation/gallery/areachart.html

<html>
  <head>
    <script type="text/javascript" src="http://www.google.com/jsapi"&gt;&lt;/script&gt;
    <script type="text/javascript">
      google.load("visualization", "1", {packages:["corechart"]});
      google.setOnLoadCallback(drawChart);
      function drawChart() {
        var data = new google.visualization.DataTable();
        data.addColumn('string', 'Year');
        data.addColumn('number', 'Sales');


       for (var i = 0; i < 10; i++) {
        data.addRows(['row'+i,i]);
    }

          var chart = new google.visualization.AreaChart(document.getElementById('chart_div'));
        chart.draw(data, {width: 400, height: 240, title: 'Company Performance',
                          hAxis: {title: 'Year', titleTextStyle: {color: '#FF0000'}}
                         });
      }
    </script>
  </head>
  <body>
    <div id="chart_div"></div>
  </body>
</html>​
+3  A: 

You're missing the parenthesis of the function call:

 for (var i = 0; i < 10; i++) {
        data.addRows(['row'+i,i]);
    }
nico  2010-08-20 11:07:01
@nico oh my god how could i missed that. Anyhow thanks for pointing it out.
Pandiya Chendur  2010-08-20 11:07:49
at least your for loop is valid :)
Stefanvds  2010-08-20 11:08:51
@Pandiya Chendur: no worries, things like that happen. You're looking so hard to find some obscure error that you don't notice obvious mistakes :)
nico  2010-08-20 11:28:48
+2  A: 

It seems your method addRows needs an array of [string, int]. Thus you'll need to do:

for (var i=0; i<10; i++) {
   data.addRows(   // parenthesis for calling a method
      [            // array of
           ['row'+i,i] // [string, int] even if it's only one
      ]);

(Spaces and enters added for clarity)

helios  2010-08-20 11:09:17
+3  A: 

The exact equivalent code would be

var rows = [];
for (var i=0; i<10; i++) {
   rows.push(['row'+i, i]);
}
data.addRows(rows);

What helios had suggested would also work except it is not exact representation of earlier code as it would make more than one call to data.addRows.

VinayC  2010-08-20 11:18:41

related questions

iterative version of easy recursive algorithm
Existing LINQ extension method similar to Parallel.For?
How to modify or delete items from an enumerable collection while iterating through it in C#
modern for loop for primitive array
Converting a List of Tuples into a Dict in Python
iterative version of recursive algorithm to make a binary tree
Why is it bad to use a iteration variable in a lambda expression
What is the easiest/best/most correct way to iterate through the characters of a string in Java?
Is Iterator initialization inside for loop considered bad style, and why?
.NET Fastest way to iterate through rows in a datatable?
Way to go from recursion to iteration
Team size and project iteration length.
Is it correct to use the backtick / comma idiom inside a (loop ...)?
Is there a zip-like method in .Net?
How do I iterate a .Net IList collection in the reverse order?
In C# .NET 2.0, what's an easy way to do a foreach in reverse?
Iterators in C++ (stl) vs Java, is there a conceptual difference?
Iterate Over Map
Lisp list iteration
Why does Python's iter() on a mapping return iterkeys() instead of iteritems()?
Replacement for for... if array iteration
Generic iterator
What's the safest way to iterate through the keys of a Perl hash?
How do I use Python's itertools.groupby()?
Using 'in' to match an attribute of Python objects in an array