views:

134

answers:

1

I need to cycle through 4 images on my site, I didn't want to add another plugin to the site, so i created my own simple carousel (html, css, and js below)

My question is, just from looking at this code, is there an obvious simpler/better way to do it?

html:

<section id="carousel">
    <img src="images/image_00.jpg" width="202" height="162" />
</section>

css:

#carousel{text-align:center;position:relative;}
#carousel img{top:0;left:0;z-index:1;position:absolute;}

js:

function carousel(el, base_url, images, i){
    if (i == images.length ) i = 0;
    var el2 = $(el).clone();
    $(el).css('z-index', '1');
    el2.css('z-index', '0');
    el2.attr('src', base_url + images[i]);
    $(el).after(el2);
    $(el).fadeOut('slow', function(){
        $(this).remove();
    });
    i++;
    var func = function(){return carousel(el, base_url, images, i);};
    window.timer = setTimeout(func, 4000);
}
$(document).ready(function(){
    carousel('#carousel img:first',
             'images/', 
             ['image_00.jpg',
              'image_01.jpg',
              'image_02.jpg',
              'image_03.jpg'], 
             0);
});
A: 

Here's my optimized version...

HTML

<!-- "section" is not valid HTML -->
<div id="carousel">
         <img src="images/01.jpg" width="202" height="162" />
</div>

CSS

/* Same as before */
#carousel{text-align:center;position:relative;}
#carousel img{top:0;left:0;z-index:1;position:absolute;}

Javascript

function carousel(el, base, images, i){
    //Made the "i" parameter optional
    if (i == images.length || i == null) i = 0;
    //Put the variables in a better order
    var el2 = $(el).clone();
    el2.attr('src', base + images[i]);
    el2.css('z-index', '0');
    $(el).css('z-index', '1');
    $(el).after(el2);
    //One line...
    $(el).fadeOut('slow', function(){$(this).remove();});
    i++;
    //The function doesn't have to be in a variable
    window.timer = setTimeout(function(){return carousel(el, base, images, i);}, 4000);
}

$(function($){
    //Didn't include "i" variable
    carousel('#carousel img:first',
             'images/', 
             ['01.jpg',
              '02.jpg',
              '03.jpg',
              '04.jpg']);
});
Mark
Thanks, but besides removing the "i" you optimized nothing.
Tombigel
Well, that's the best I can do, I think its as optimized as it can get
Mark