Does anyone see anything wrong with this? Mysql+PHP Error

Question

I'm running the following line :

mysql_query("INSERT INTO tags 
                SET tag = '".$onesearch."',  
                SET date = '".date('d-m-Y')."'") or die(mysql_error());

...and its dieing saying this:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'SET date = '29-08-2010'' at line 1

I can't figure out what's wrong.

Answer 1

Are you able to output the query that is actually being run? It could be that the tag contains a single quote, which escapes the closing quote & causes problems... Which is why you'd want to use:

mysql_query("INSERT INTO tags 
                SET tag = '". mysql_real_escape_string($onesearch) ."',  
                    date = '".date('d-m-Y')."'") or die(mysql_error());

Which is it you're trying to do here?
You start with INSERT syntax, but after the table reference convert to using UPDATE syntax.

INSERT

mysql_query("INSERT INTO tags 
               (tag, date) 
             VALUES 
               ('".$onesearch."', '".date('d-m-Y')."')") or die(mysql_error());

UPDATE

mysql_query("UPDATE tags 
                SET tag = '".$onesearch."',  
                    date = '".date('d-m-Y')."'") or die(mysql_error());

...but you'll get records in the table to those two values. You'd want a WHERE clause on that...

Answer 2

Invalid syntax, you should only use one SET:

mysql_query("INSERT INTO tags 
            SET tag = '".$onesearch."',  
            date = '".date('d-m-Y')."'") or die(mysql_error());

And that is valid INSERT syntax, just an FYI (in response to one of the other answers).

Answer 3

Remove second SET from your insert query. it should like be:

mysql_query("INSERT INTO tags 
                SET tag = '".$onesearch."',  
                date = '".date('d-m-Y')."'") or die(mysql_error());

Answer 4

i think your question was already answered by the others. but you should take care of that $onesearch variable. if it's not properly sanitized, a quote in it could break your code as well. if you are not doing it already, you should consider using mysql_real_escape_string() to protect you from errors and sql injection.