Optimization resulting unreachable code

Question

i created one flag Method1HasExecuted ,,the logic which i wanted to achieve is if that flag true i need to do this function rp = Spa.Modify(val); otherwise return rp as false.For that i did like this

        if (Method1HasExecuted)
        {
            rp = Spa.Modify(val);//Save operation, this function also return boolean value
        }
        else rp = false;

Then for optimization i used ternary operator and did like this

return Method1HasExecuted ? Spa.ClientModify() : false;

But by doing this way down side i saw some unreachable code which was already there like this

1.how to make it reachable or here using ternary operator is not required?

2.After catch block we can see return retval; on bottom is that required since the outcome of all work is either true which will do the Save operation or false means display serverdown,which already there in my work

for second question the whole structure is like this now

Answer 1

Your problem is that you're using the RETURN..

you should do:

rp = Method1HasExecuted ? Spa.ClientModify() : false;

and the rest should be the same..

remember.. return will just return :)

Answer 2

You translated an if-else statement into a ternary operator, but you also added a return statement. The problem is that the return statement will always return, so if you have code below that in that method, it will never get executed.

You can keep the ternary operator, just don't return:

rp = Method1HasExecuted ? Spa.ClientModify() : false;

The ternary operator will produce IL very similar to the if-else statement you had before. It will not be materially faster, so only use it if you think it improves maintainability or readability of the code.

Answer 3

Actually, you should do:

rp = Method1HasExecuted && Spa.ClientModify();