tags:

views:

220

answers:

6

For examples I don't know how many rows in each table are and I try to do like this:

SELECT * FROM members 
UNION 
SELECT * FROM inventory

What can I put to the second SELECT instead of * to remove this error without adding NULL's?

+1  A: 

Put the columns names explicitly rather than *, and make sure the number of columns and data types match for the same column in each select.

Update:

I really don't think you want to be UNIONing those tables, based on the tables names. They don't seem to contain related data. If you post your schema and describe what you are trying to achieve it is likely we can provide better help.

RedFilter
I know nothing about any names, nothing. Is it still possible?
hey
Why was this downvoted?
OMG Ponies
@hey: Use `DESC your_table_name` to find out the columns and their data types before writing the UNION query.
OMG Ponies
@hey: see my update
RedFilter
Actually I found SQL Injection in one site...
hey
@hey: Umm... sorta non-sequitor there... if you type the column names in manually, you will reduce the risk of SQL injection.
FrustratedWithFormsDesigner
"I like turtles!"
RedFilter
@Frus SQL injection!?!?!? What in tarnation are you talking about? `SELECT *` vs. `SELECT Col1, Col2` has absolutely **nothing** to do with SQL injection.
Emtucifor
@Emtucifor: It was `hey` that brought up the topic of SQL injection. My guess is that `hey` thought `SELECT * ` could lead to SQL injection. I used to have a manager who would also worry about that so insisted that column names be always be explicit. It didn't make much sense to me, but it felt like that guy and `hey` took the same classes in school...
FrustratedWithFormsDesigner
@Frus oops, I meant to address that to hey, sorry about that. Let me try again.
Emtucifor
@hey SQL injection!?!?!? What in tarnation are you talking about? SELECT * vs. SELECT Col1, Col2 has absolutely nothing to do with SQL injection.
Emtucifor
@Emtucifor: no worries ;)
FrustratedWithFormsDesigner
A: 

you don't know the rows but you should know the columns!

vulkanino
Let's say I know nothing.
hey
Ok, you know nothing. Now run 'SELECT * FROM members'. Now you know columns.
mluebke
"Let's say I know nothing."Then you have no business querying the database.
HLGEM
A: 

you could do

SELECT *
from members
UNION
SELECT inventory.*, 'dummy1' AS membersCol1, 'dummy2' AS membersCol2
from inventory;

Where membersCol1, membersCol12, etc... are the names of columns from members that are not in inventory. That way both queries in the union will have the same columns (Assuming that all the columns in inventory are the same as in members which seems very strange to me... but hey, it's your schema).

UPDATE:

As HLGEM pointed out, this will only work if inventory has columns with the same names as members, and in the same order. Naming all the columns explicitly is the best idea, but since I don't know the names I can't exactly do that. If I did, it might look something like this:

SELECT id, name, member_role, member_type
from members
UNION
SELECT id, name, '(dummy for union)' AS member_role, '(dummy for union)' AS member_type
from inventory;

I don't like using NULL for dummy values because then it's not always clear which part of the union a record came from - using 'dummy' makes it clear that the record is from the part of the union that didn't have that record (though sometimes this might not matter). The very idea of unioning these two tables seems very strange to me because I very much doubt they'd have more than 1 or 2 columns with the same name, but you asked the question in such a way that I imagine in your scenario this somehow makes sense.

FrustratedWithFormsDesigner
Why not use `NULL` instead of 'dummy1' and 'dummy2'?
dan04
Even if this would work, you still need to specify column names as the columns may or may not be in the same order on both tables (or stay in the same order forever). Plus if inventory then had anopther column added, the union would break. Never do a UNOIN without specifying the columns. Also all unions should be considered as candiates fro UNION ALL which is much more performant if there is no possiblity of dupes that need to be filtered out.
HLGEM
Telling how to do something that is so obviously incorrect is hurting the poor chap asking the question, not helping him.
Emtucifor
@Emtucifor: Considering his question barely made sense (union two completely different tables), I don't really see what's wrong with this answer. It would work for what he wants to do. *WHY* he wants to do that is something else entirely.
FrustratedWithFormsDesigner
+1  A: 

Are you sure you don't want a join instead? It is unlikely that UNOIN will give you what you want given the table names.

HLGEM
A: 

What is the Business Requirements here? Are you sure you want to return all records from these two seemingly unrelated tables? (Although in case of UNION you'll get distinct records).

Naomi
A: 

I don't know how many rows in each table

Are you sure this isn't what you want?

SELECT 'members' AS TableName, Count(*) AS Cnt FROM members 
UNION ALL
SELECT 'inventory', Count(*) FROM inventory
Emtucifor