views:

223

answers:

2

i came across a compatibility issue today, as a customer upgraded from Windows XP to Windows 7.

The (12 year old code) is calling a stored procedure on the SQL Server called

ai_nextid

Except that when it calls the stored procedure it is using the name:

ai_nextid;1

Yes, with a ";1" appended. Apparently the SQL Server driver in Windows 95, Windows 2000, Windows XP, and possibly Windows Vista, are fine with this specifically added suffix. But the SQL Server ODBC driver in Windows 7 is different, and causes the error:

General SQL Error.
[Microsoft][ODBC SQL Driver][SQL Server]Could not find stored procedure 'ai_nextid;1'.
[Microsoft][ODBC SQL Driver][SQL Server]Indicator variable requried but not supplied'.

With native error 2812.

This brings up 4 questions:

  • why were we appending ;1 to the end of the stored procedure name? (what does it accomplish)
  • why was the SQL Server driver ignoring it?
  • why was a breaking change made in Windows 7?
  • is the breaking compatibility change documented?

The last two questions would probably be the same, since if they document it, they would justify it.

+7  A: 

see CREATE PROCEDURE (Transact-SQL) SQL Server 2008 documentation

--Transact-SQL Stored Procedure Syntax
CREATE { PROC | PROCEDURE } [schema_name.] procedure_name            [ ; number ]  <<<<<<
    [ { @parameter [ type_schema_name. ] data_type } 
        [ VARYING ] [ = default ] [ OUT | OUTPUT ] [READONLY]
    ] [ ,...n ] 
[ WITH <procedure_option> [ ,...n ] ]
[ FOR REPLICATION ] 
AS { [ BEGIN ] sql_statement [;] [ ...n ] [ END ] }
[;]

<procedure_option> ::= 
    [ ENCRYPTION ]
    [ RECOMPILE ]
    [ EXECUTE AS Clause ]

;number

An optional integer that is used to group procedures of the same name. These grouped procedures can be dropped together by using one DROP PROCEDURE statement.

Note:

This feature will be removed in a future version of Microsoft SQL Server.
    Avoid using this feature in new development work, and plan to
    modify applications that currently use this feature.

Numbered procedures cannot use the xml or CLR user-defined types and cannot be used in a plan guide.

you can use this system view to find all of these and begin to rewrite them as separate procedures:

sys.numbered_procedures (Transact-SQL)

KM
What is confusing is that all that changed in the client machines; upgraded to Windows 7. So the feature still exists *on the server* - but has been removed from the client driver.
Ian Boyd
+4  A: 
  • why were we appending ;1 to the end of the stored procedure name? (what does it accomplish)

The ;1 means that you are calling Numbered Stored Procedures. You can have InsertOrders;1, InsertOrders;2, InsertOrders;3 as different versions with the same name. When you do a DROP on the InsertOrders, all numbered versions are dropped. This was a poor man's implementation of overloading.

  • why was the SQL Server driver ignoring it?

The old SQL Server driver either knew what a numbered proc was, or was not smart enough to parse and compile that portion of code.

  • why was a breaking change made in Windows 7?

  • is the breaking compatibility change documented?

This will not be supported in a future version, but R2 supports numbered stored procs. I have personally never put numbered procs in production - only played with them, said "oh cool" and moved on.

Raj More