Parse error when trying to display a hyperlink

Question

Hello,

The link below is giving me the error Parse error: syntax error, unexpected T_STRING. Any idea how to fix it?

Thanks in advance,

John

$link1 = "<a href='http://www.domain.com/path/comments/index.php?submission=".urlencode($submission)."&amp;submissionid=".urlencode($submissionid)."&amp;url=".urlencode($url)."&amp;countcomments=".urlencode($countcomments)."&amp;submittor=".urlencode($submittor)."&amp;submissiondate=".urlencode($submissiondate)."&amp;dispurl=".urlencode($dispurl)."'&gt;'".Comment Link."'</a>'");

Answer 1

Like this:

$link1 = "<a href='http://www.domain.com/path/comments/index.php?submission=".urlencode($submission)."&amp;submissionid=".urlencode($submissionid)."&amp;url=".urlencode($url)."&amp;countcomments=".urlencode($countcomments)."&amp;submittor=".urlencode($submittor)."&amp;submissiondate=".urlencode($submissiondate)."&amp;dispurl=".urlencode($dispurl)."'&gt;Comment Link</a>";

By doing this:

".Comment Link."

PHP thinks Comment Link is code, which it obviously is not.

Answer 2

You had extra ) and unnecessary concatenation, here is the correct version:

$link1 = "<a href='http://www.domain.com/path/comments/index.php?submission=".urlencode($submission)."&amp;submissionid=".urlencode($submissionid)."&amp;url=".urlencode($url)."&amp;countcomments=".urlencode($countcomments)."&amp;submittor=".urlencode($submittor)."&amp;submissiondate=".urlencode($submissiondate)."&amp;dispurl=".urlencode($dispurl)."&gt;Comment Link</a>";

echo $link1;

Answer 3

1. If "Comment Link" is the text of the anchor tag, it should come inside the double quotes. But you have put it outside the double quotes in such a way that it is interpreted as PHP code.

   You were doing something like:

   $link = "<a href='" . $pageurl . "'>" . Comment Link . "</a>"

   But you should have done something like:

   $link = "<a href='" . $pageurl . "'>Comment Link</a>"

2. You also had an extra ) in the end.

3. So your actual code should be

   $link1 = "<a href='http://www.domain.com/path/comments/index.php?submission=".urlencode($submission)."&amp;submissionid=".urlencode($submissionid)."&amp;url=".urlencode($url)."&amp;countcomments=".urlencode($countcomments)."&amp;submittor=".urlencode($submittor)."&amp;submissiondate=".urlencode($submissiondate)."&amp;dispurl=".urlencode($dispurl)."'&gt;Comment Link</a>";