views:

243

answers:

2

I know there are a lot of threads here already on the repository pattern but somehow I feel my question is a little different. May be because yesterday was the first time I heard of the word POCO.

My question is this--usually, I have add and save methods in my business entities. Say I am writing a Q/A site, and I have the following entities: questions, answers, and comments. If I wanted to use the repository pattern, I basically need to keep only the properties in my business entities (example, Question), and move my operations to the repository class (example, QuestionRepository), right? If this is true, does POCO mean a business entity with just the properties?

I'm using Entity Framework 4.0, which created my entities in the edmx code behind. If I wanted to use the repository pattern with this, there is no need to write my own business entities (Question, Answer, etc) since they are already generated by EF, right? All I'd need is the Repository to do CRUD? And I'll be having three repositories for this example, one for each entity?

+2  A: 

Your POCO objects would still have methods on them for operations, but those operations would pertain to the business concerns of the entity not the persistence concerns(CRUD). If there are no business operations on your entites, then yes they will be just properties.

You wouldn't need to write your pocos from scratch if you are generating them but you may want to extend them with partial classes for business operations and non-persistent or calculated properties.

You could have a single repository class or a repository for each entity.

PhilB
I think this is incorrect - if you're using the repository pattern your business objects don't contain the operations - that is all delegated to repositories. So your User object will have a Name, Surname, etc but your UserRepository object will have GetUsers and SaveUser methods
Jaco Pretorius
@Jaco Pretorius: The question object could have operations for AddAnswer, Close, SelectAnswer, etc which would be business concerns. The question object would not have operations for Save, Get, Update, or Delete as these are persistence concerns and would be the responsibility of the repository. Having no operations on your business objects leads to an anemic domain model http://en.wikipedia.org/wiki/Anemic_Domain_Model which is often considered an anti-pattern.
PhilB
I agree with PhilB, we use only repository for persistent concerns, entity can has as many its own operation as needed for handling its business logic.
Tiendq
+9  A: 

First an observation about MVC pattern

I must say that Visual Studio has a tiny flaw in Asp.net MVC project template. And that is the Model folder. People not knowing MVC pattern would automatically relate this to data model and not MVC application model. This is fine for simple applications but not for anything else.

Let's continue to my answer

When I write business level applications I separate my solution into 4 projects (at least):

  • presentation tier - Asp.net MVC application but I remove Model folder and have all my views as strong type views to avoid magic strings as much as possible
  • service tier - business logic processes
  • data tier - data model ie. EF4 and repositories that access this model
  • objects tier - this project actually has POCOs that are used for inter-project communication

My request process usually looks very clean and works this way:

  1. When a request is made my Asp.net MVC controller action validates data, does whatever is necessary for the presentation tier before calling into services.
  2. Service is called that does whatever business process logic requires and normally calls repository to do something with data.
  3. Repository manipulates data in the data model and then creates POCOs from results that will be returned to service layer.
  4. Service layer receives POCOs does additional logic if needed and returns them back to presentation.
  5. Presentation (controller) decides which view to display and provides model for that particular view and returns it. Of course instead of a view it can be any other result as well.

Advantage of using separate MVC model classes in Objects project (you couldn't put them in the Model folder because of circular project reference) is that I can have presentation optimised classes. Or better said: I have business process centric interface instead of data centric.

Let's emplain this with an example: Take for instance user registration view. It can't be strong typed to data model's User entity. Why? Because it has two inputs for password. So I can have a POCO application model class called UserRegistration even though there's nothing similar in data model. Its validation works completely different compared to data model's User entity. If I'd have my user registration done without strong type I'd have to make my controller action with all parameters of every single field. These wouldn't be automatically validated which would mean that I can have a bigger surface for bugs. Someone might hurry into writing code but forgets certain aspects of validation.

Strong type views returning strong types back at server are the safest way of getting rid of all kinds of obscure bugs that are usually discovered by users especially if you don't do any methodical testing on your project (which is somewhere between 75-90% chance).

Robert Koritnik
I can't upvote this enough! I've said the exact thing many times and I usually get comments to the regard of YAGNI or I'm crazy, which tells me most people are just writing simple CRUD apps that wouldn't benefit from these ideas. It's the primary reason I'm not very active here anymore. Any suggestion beyond "do what MSFT says" gets ignored by most people.
Ryan
@Ryan: Thank you very much. Though I haven't seen developers here blind-following some company's views. At least not as much to draw me away from the site.
Robert Koritnik