views:

129

answers:

6

Recently I was running some of my code through JSLint when I came up with this error. The thing I think is funny about this error though is that it automatically assumes that all == should be ===.

Does that really make any sense? I could see a lot of instances that you would not want to compare type, and I am worried that this could actually cause problems.

The word "Expected" would imply that this should be done EVERY time.....That is what does not make sense to me.

Metropolis

+1  A: 

Well it can't really cause problems, it's just giving you advice. Take it or leave it. That said, I'm not sure how clever it is. There may well be contexts in which it doesn't present it as an issue.

Rushyo
but why is the word "Expected" used? That makes it sound like you should always do this.
Metropolis
The evaluator is looking for a valid response, as it's trying to validate it. If it doesn't get a valid response, then it's not what it expected. The validator starts with the assumption that everything is fine and then points out errors as it traverses the code. It doesn't necessarily understand what is an invalid response, it just knows when it sees a non-valid one. It could also work in the reverse, deliberately searching for bad code according to rules of what is bad. Whitelisting vs blacklisting.
Rushyo
+5  A: 

Keep in mind that JSLint enforces one persons idea of what good JavaScript should be. You still have to use common sense when implementing the changes it suggests.

In general, comparing type and value will make your code safer (you will not run into the unexpected behavior when type conversion doesn't do what you think it should).

Justin Niessner
Plus it cannot be as context-smart as a programmer. It's just working on the basis that most users get tripped up by auto type conversion inherent in the system (like violence - "help help I'm being repressed!")
Rudu
A: 

A quote from http://javascript.crockford.com/code.html:

=== and !== Operators.

It is almost always better to use the === and !== operators. The == and != operators do type coercion. In particular, do not use == to compare against falsy values.

JSLint is very strict, their 'webjslint.js' does not even pass their own validation.

Lekensteyn
+1  A: 

JSLint is inherently more defensive than the Javascript syntax allows for.

From the JSLint documentation:

The == and != operators do type coercion before comparing. This is bad because it causes ' \t\r\n' == 0 to be true. This can mask type errors.

When comparing to any of the following values, use the === or !== operators (which do not do type coercion): 0 '' undefined null false true

If you only care that a value is truthy or falsy, then use the short form. Instead of

(foo != 0)

just say

(foo)

and instead of

(foo == 0)

say

(!foo)

The === and !== operators are preferred.

Daniel Vandersluis
+5  A: 

IMO, blindly using ===, without trying to understand how type conversion works doesn't makes much sense.

The primary fear about the Equals operator == is that the comparison rules depending on the types compared can make the operator non-transitive, for example, if:

A == B AND
B == C

Doesn't really guarantees that:

A == C

For example:

'0' == 0;   // true
 0  == '';  // true
'0' == '';  // false

The Strict Equals operator === is not really necessary when you compare values of the same type, the most common example:

if (typeof foo == "function") {
  //..
}

We compare the result of the typeof operator, which is always a string, with a string literal...

Or when you know the type coercion rules, for example, check if something is null or undefinedsomething:

if (foo == null) {
  // foo is null or undefined
}

// Vs. the following non-sense version:

if (foo === null || typeof foo === "undefined") {
  // foo is null or undefined
}
CMS
+1, well-illustrated answer
Jakob
@Jakob: Thanks!
CMS
A: 

Tripple-equal is different to double-equal because in addition to checking whether the two sides are the same value, it also checks that they are the same data type.

So ("4" == 4) is true, whereas ("4" === 4) is false.

Tripple-equal also runs slightly quicker, because Javascript doesn't have to waste time doing any type conversions prior to giving you the answer.

JSLint is deliberately aimed at making your Javascript code as strict as possible, with the aim of reducing obscure bugs. It highlights this sort of thing to try to get you to code in a way that forces you to respect data types.

But the good thing about JSLint is that it is just a guide. As they say on the site, it will hurt your feelings, even if you're a very good JS programmer. But you shouldn't feel obliged to follow its advice. If you've read what it has to say and you understand it, but you are sure your code isn't going to break, then there's no compulsion on you to change anything.

You can even tell JSLint to ignore categories of checks if you don't want to be bombarded with warnings that you're not going to do anything about.

Spudley
I did not ask "What is ===", so I am not sure why you answered it.
Metropolis
@Metropolis: if for no other reason, then as background in case someone else read the answer who didn't know. I did try to answer your question in the paragraphs after that, though.
Spudley