ansaurus

Question

Radio Button producing undefined value in javascript function

Answer 1

+1 A:

Try with document.getElementsByTagName like this:

 function jobWindow(){
  var myvalue;
  var el = document.getElementsByTagName('input');

  for( i = 0; i < el.length; i++ ){
   if (document.forms['jobView'].el[i].type === 'radio' && document.forms['jobView'].el[i].name === 'sales')
   {
     if(document.forms['jobView'].el[i].checked == true )
     {
       myvalue = document.forms['jobView'].el[i].value;
       break;
     }
   }
  }
  alert( "val = " + myvalue );
 }

Note also that your break line never executed because you were missing curly brackets:

if( document.jobView.sales[i].checked == true )
{
   target = document.jobView.sales[i].value;
   break;
}

Sarfraz 2010-09-17 21:16:25

I added the missing curly braces and it worked. Thanks for the catch

shinjuo 2010-09-17 21:34:51

Answer 2

+1 A:

throw some debugging in there. for example put an alert() inside the for() statement to make sure it is getting a definition for document.jobView.sales.length.

If it doesn't make the alert, you can almost bet document.jobView.sales.length is undefined.

You can then do try { var length = document.jobView.sales.length; } catch(e) { alert(e); } to verify this.

If you verify that document.jobView.sales.length isn't being defined, you may have to use document.getElementsByTagName, and loop through them instead of document.jobView

Alex 2010-09-17 21:19:41

Answer 3

+1 A:

change document.jobView.sales to document.getElementsByName('sales')

Vinay B R 2010-09-17 21:20:49

Answer 4

+1 A:

The access path you actually want is:

var el = document.forms["jobView"].elements["sales"];

The straight dot chain (document.jobView.sales) makes an implicit call to the "all" collection, which will only work in IE. (Yes, I know that Firefox returns an identical-looking string in its error console when things go wrong, but you can't actually use it in your own code.) getELementsByTagName() and getElementsByName() will work just fine, but then you need to ensure that the elements in the returned collection are the ones you actually want. (Assume that a time will come when you want to create more than one form on the page, and that field names will collide. It will never happen, of course, unless you fail to make that assumption out of the gate, whereupon another developer will immediately add a second form to the page you just committed.)

Stan Rogers 2010-09-18 02:08:05

ansaurus

tags:

views:

answers:

Radio Button producing undefined value in javascript function

related questions