ansaurus

Question

PHP/MySQL Insert

Answer 1

+6 A:

Actually I do see 1 error..."Option" is a reserved word. wrap it in backtics : `Option` or better yet, change the column name to something that's not a reserved word.

Crayon Violent 2010-09-18 20:35:24

Precisely the problem. Thank you.

Glenn Nelson 2010-09-18 20:38:07

Answer 2

+2 A:

Looking at the code you're trying to insert what comes from $_POST['survey'], so your insert should look like this:

$vote = $_POST['survey'];

// connect to db

mysql_query(sprintf(
    "INSERT INTO poll (`Option`) VALUES ('%s')", 
    mysql_real_escape_string($vote)
);

Also note that "option" is a reserved keyword and needs to be inside backticks.

halfdan 2010-09-18 20:36:00

You forgot `sprintf` :)

Fanis 2010-09-18 20:42:07

@Fanis: God, what a FAIL :-( Fixed it.

halfdan 2010-09-18 21:08:55

Answer 3

+3 A:

Use backticks for 'option'.

INSERT INTO poll (`Option`) VALUES ('Stuff')

vassilis 2010-09-18 20:36:04

Or just do `INSERT INTO poll VALUES ('Stuff')`. There's no need to specify the column name.

Mark Snidovich 2010-09-18 20:39:35

@Mark Snidovich - well that's only true if you plan on providing values for every column (and in the right column order). In general that isn't very good practice though, because if you decide to add another column to the table later on, for some other script...it's going to break this statement.

Crayon Violent 2010-09-18 20:43:03

@Crayon that's true, but in this case, the table has only one column. That is how I do things, generally - provide a value for each column and if I change the table, I'd better be careful. Good points though, i guess it depends if you want resiliency or would rather to be forced to be precise in the values provided.

Mark Snidovich 2010-09-19 02:18:25

ansaurus

tags:

views:

answers:

PHP/MySQL Insert

related questions