views:

144

answers:

4

If I try something such as:

int anint;
char achar;

printf("\nEnter any integer:");
scanf("%d", &anint);
printf("\nEnter any character:");
scanf("%c", &achar);
printf("\nHello\n");
printf("\nThe integer entered is %d\n", anint);
printf("\nThe char entered is %c\n", achar);

It allows entering an integer, then skips the second scanf completely, this is really strange, as when I swap the two (the char scanf first), it works fine. What on earth could be wrong?

+2  A: 

It doesn't skip the second scanf(); the second scanf() reads the newline left behind by the first scanf(). Most format codes skip white space; the %c format does not skip white space.

Jonathan Leffler
+5  A: 

When reading input using scanf, the input is read after the return key is pressed but the newline generated by the return key is not consumed by scanf, which means the next time you read a char from standard input there will be a newline ready to be read.

One way to avoid is to use fgets to read the input as a string and then extract what you want using sscanf as:

char line[MAX];

printf("\nEnter any integer:");
if( fgets(line,MAX,stdin) && sscanf(line,"%d", &anint)!=1 ) 
   anint=0;

printf("\nEnter any character:");
if( fgets(line,MAX,stdin) && sscanf(line,"%c", &achar)!=1 ) 
   achar=0;

Another way to consume the newline would be to scanf("%c%*c",&anint);. The %*c will read the newline from the buffer and discard it.

You might want to read this:

C FAQ : Why does everyone say not to use scanf?

codaddict
You'd need the `%*c` after the `%d` format (too, or instead), wouldn't you? Though even that is not reliable - if the user typed a space or something after the number and before the newline. I think `fgets()` + `sscanf()` is better.
Jonathan Leffler
@Jonathan: You are right. We would need it after the `%d`. And yes `fgets + sscanf` is always better.
codaddict
Why do you not link to my EXACT EQUAL SOLUTION on http://stackoverflow.com/questions/3723768/help-with-c-scanf-syntax/3728189#3728189 ?
@codeaddict: Sorry for lengthy accept, but you really did give me some more insight on how the internals work in C. I really appreciate the C FAQ link too, all the better to be wise to teach new people these things, if I ever get to help people out later on.
John
+2  A: 

The other answers are correct - %c does not skip whitespace. The easiest way to make it do so is to place whitespace before the %c:

scanf(" %c", &achar);

(Any whitespace in the format string will make scanf consume all consecutive whitespace).

caf
+1  A: 

Try also _flushall() after each printf call. . Basically, by default MS’s C++ buffers stream output, and the the flushing causes the output stream to empty.

rursw1