views:

191

answers:

5

I have a problem with converting a text file from ANSI to UTF8 in c#. I try to display the results in a browser.

So I have a this text file with many accent character in it. Its encoded in ANSI, so I have to convert it to utf8 because in the browser instead of the accentchars appearing "?". No matter how I tried to convert to UTF8 it was still a "?". But if I convert the text file in notepad++ to utf8 then the accent chars are desplayed good.

here is a peace of encoding code that I made:

    public string Encode(string text)
    {
        // encode the string as an ASCII byte array
        byte[] myASCIIBytes = ASCIIEncoding.ASCII.GetBytes(text);

        // convert the ASCII byte array to a UTF-8 byte array
        byte[] myUTF8Bytes = ASCIIEncoding.Convert(ASCIIEncoding.ASCII, UTF8Encoding.UTF8, myASCIIBytes);

        // reconstitute a string from the UTF-8 byte array 
        return UTF8Encoding.UTF8.GetString(myUTF8Bytes);
    }

Do you have any idea why is this happening?

+3  A: 

Do you have any idea why is this happening?

Yes, you're too late. You need to specify ANSI when you read the string from file. In memory it's always Unicode (UTF16).

Henk Holterman
+1 Yup, the text is already destroyed before it enters the function.
Hans Passant
A: 

My thoughts here is when you save the file in Notepad++ it inserts the Byte-Order-Mark so the browser can infer that it's UTF8 from this. Otherwise you'd probably have to explicitly tell the browser the character encoding, as in the DTD, in XML etc.

Lloyd
A: 

This is probably happening because your original string text already contains invalid characters. Encoding conversion only makes sense if your input is a byte array. So, you should read the file as byte array instead of string, or, as Henk said, specify the encoding for reading the file.

Rotsor
+2  A: 

when you convert to ASCII you immediately loose all non-English characters (including ones with accent) because ASCII has only 127 (7 bits) of characters.

You do strange manipulation. string in .net is in UTF-16, so once you return string, not byte[] this doesn't matter.

i think you should do: (i guess by ANSI you mean Latin1)

public byte[] Encode(string text)
{
    return Encoding.GetEncoding(1252).GetBytes(text);
}

since question was not very clear there is a reasonable remark that you might actually need this one:

public string Decode(byte[] data)
{
    return Encoding.GetEncoding(1252).GetString(data);
}
Andrey
+1 for the CodePage stuff, But I think you have the wrong direction here. The Op needs to read `byte[]` and a function to convert it **to** `string`.
Henk Holterman
@Henk Holterman i have a feeling that i misunderstood the asker. but his function takes `string` and returns `string` so i am not sure
Andrey
I think we need a `string Decode(byte[])`
Henk Holterman
@Henk Holterman what for?
Andrey
The OP reads ASCII (ANSI/Latin1/...)
Henk Holterman
@Henk Holterman what is `string Decode(byte[])`? i don't know this method. `GetByte` return bytes for given encoding, what's wrong with it?
Andrey
My Decode is the mirror of your Encode.
Henk Holterman
A: 

I would recommend to read this http://www.joelonsoftware.com/articles/Unicode.html.
If you are going to read a ASCII file you need to know the code page of the file.

sh_kamalh