views:

222

answers:

4

I've run across this "Incompatible types" error in the comment below a few times, and never been happy with why this isn't directly supported in Delphi 2007:

program Project1; {$APPTYPE CONSOLE}

type TCharArray = array of Char;

procedure DoArray(Chars: array of Char);
begin
end;

function ReturnTCharArray: TCharArray;
var CharArray: TCharArray;
begin
  Result := CharArray;
end;

begin
  DoArray(ReturnTCharArray); // [DCC Error] Project1.dpr(18): E2010 Incompatible types: 'Array' and 'TCharArray'
end.

Shouldn't it be possible to make an array type "aliased" to another array type compatible with each other? Assuming I can't change the declaration of DoArray (it is part of a third party library), how do I write a function returning an array of char compatible with DoArray's param? The straightforward "function ReturnAChar: array of Char;" results in an "Identifier expected but 'ARRAY' found" error. I even tried changing the function returning the array to a procedure with a var "array of Char" pram, but that also doesn't allow setting the length of the "array of Char" param in the procedure ("Constant object cannot be passed as var parameter").

+5  A: 

You don't. Pascal handles array types by name, not by description, and always has. Why can't you change the declaration of DoArray? (And why was it written like that in the first place?)

Mason Wheeler
+1; right! (Oh BTW: there is also the "open array" versus "typed array" thing, that's probably where the Anagoge is going to bump into next)
Jeroen Pluimers
DoArray is part of a third party library that I don't want to (and realistically can't) edit. I can understand you sometimes want the type safety of types by name, but this language restriction is more annoying than helpful, to me. Is there not a way to convince Delphi to return a literal/exact "array of Char" from a function? That seems like a fairly basic request.
Anagoge
@Anagoge: No, there isn't as far as I know. I think that's why they added `TArray<T>` in Delphi 2009. `TArray<T>` is defined as `array of T`, but since it's now a named type, it gets around all these issues.
Mason Wheeler
For some reason, I always thought that dynamic arrays and open arrays were incompatible...
Ken Bourassa
+2  A: 

When typed @ operator is off the compiler does not check what you assign to a pointer, so you can call a procedure with wrong parameters:

program Project1; {$APPTYPE CONSOLE}

type TCharArray = array of Char;

procedure DoArray(Chars: array of Char);
begin
end;

function ReturnTCharArray: TCharArray;
var CharArray: TCharArray;
begin
  Result := CharArray;
end;

type TFakeDoArray = procedure(Chars: TCharArray);

var
  FakeDoArray: TFakeDoArray;
begin
  FakeDoArray := @DoArray;
  FakeDoArray(ReturnTCharArray);
end.

While the compiler won't complain, for the very reason 'Jeroen' indicates in his comment for Mason's answer, this will not work.

You can then try declaring your fake procedure compatible with one with an open array parameter:

program Project1; {$APPTYPE CONSOLE}

type TCharArray = array of Char;

procedure DoArray(Chars: array of Char);
begin
end;

function ReturnTCharArray: TCharArray;
var CharArray: TCharArray;
begin
  Result := CharArray;
end;

type
  TFakeDoArray = procedure(AnArray: Pointer; High: Integer);

var
  FakeDoArray: TFakeDoArray;
  Tmp: TCharArray;
begin
  FakeDoArray := @DoArray;
  Tmp := ReturnTCharArray;
  FakeDoArray(Tmp, High(Tmp));
end.

Credits are due Rudy for his great article. And the relevant documentation (from Program Control):

An open-array parameter is passed as two 32-bit values. The first value is a pointer to the array data, and the second value is one less than the number of elements in the array.

Sertac Akyuz
+1, not for the semicolon abuse, but for an interesting discussion.
Andreas Rejbrand
@Andreas - I know I'm horrible with punctuation, sorry.. Feel free to edit.
Sertac Akyuz
+1  A: 

One point that I didn't see mentioned yet is that TCharArray is a dynamic array type, while in

procedure DoArray(Chars: array of Char); 

Chars is an open array parameter. There is no syntax to declare a dynamic array parameter. To have a dynamic array parameter, it needs to be declared as a type.

type
  TMyDynArray = array of Integer;

procedure DoArray(Integers : TMyDynArray);
Ken Bourassa
+1  A: 

This may actually be a compiler bug (or a limitation that was never documented properly). I did some experimentation and found that you can pass a dynamic array (typed or not) to a procedure expecting an open array for almost every type... except Char and WideChar.

See http://stackoverflow.com/q/3781691/71200 for a description of the problem and a possible work around.

codeelegance
For some reason, I always thought that dynamic arrays and open arrays were incompatible... I'm actually pretty surprised only char and Widechar are. Looks like they were those involved in my early experimentation with Delphi arrays, and I never went back to it. Or maybe it was in Delphi 5?
Ken Bourassa
@Ken The documentation claims open array parameters can handle any array of the same type. So I was just as surprised that array of Char and array of WideChar didn't compile.
codeelegance