How to Fix "Not all code paths return a value"?

Question

I have an object array that i'm returning to use the objects in a different method, however for some reason it's saying "not all code paths return a value"

Here's the code....

private object[] runTests(string banText, object tabControlName, int runThisTest, string testName)
    {
        if (stopTests == false)
        {
            var tabPageBrowser = new TabPage();
            var Browser = new WebBrowser();

            (tabControlName as TabControl).TabPages.Add(tabPageBrowser);
            tabPageBrowser.Name = tabControlName.ToString();
            tabPageBrowser.Text = testName;
            tabPageBrowser.Font = new System.Drawing.Font("Trebuchet MS", 8.25F,
                System.Drawing.FontStyle.Regular, System.Drawing.GraphicsUnit.Point, ((byte)(0)));
            Browser.Dock = DockStyle.Fill;
            Browser.Url = new Uri(testStrings(runThisTest, banText));
            Browser.Name = tabControlName.ToString();
            Browser.ScriptErrorsSuppressed = true;
            tabPageBrowser.Controls.Add(Browser);

            try
            {
                while (Browser.ReadyState != WebBrowserReadyState.Complete)
                {
                    Application.DoEvents();
                }
            }
            catch
            {
                return null;
            }
            IntPtr pHandle = GetCurrentProcess();
            SetProcessWorkingSetSize(pHandle, -1, -1);

            object[] browserObjects = new object[2];
            browserObjects[0] = tabPageBrowser;
            browserObjects[1] = Browser;

            if (browserObjects != null)
            {
                return browserObjects;                    
            }
        }
    }

I dont see what i'm doing wrong, can you please assist? Thank you!

Answer 1

Hint: try to find a path that doesn't run through any return.

Answer 2

The method does not return if

stopTests == true

- or -

browserObjects == null

Answer 3

return browserObjects;     

ditch the if statement. technically that if statement will always hit, but compiler doesn't go that deep (code contracts would go that deep though)

Answer 4

Return a value in all code paths

Answer 5

Getter or accessor method must always return a primitive value or an object.

In your example you are saying

private object[] runTests(...) // Which means that no matter what, this method must return object[] or throw an exception

Than you have a condition:

if(my_condition_is_met)
{
 do_some_processing();
}

Now, if condition isn't met, than you are not going to return anything, when in the first line we've said that we are going to return array of objects.

Primitive, but hopefully makes sense...

Answer 6

in you code you don't have else part so here i've retrn null.

    if (stopTests == false) 
    {
        //your code 
    }
    else
        return null;