check field formmail

Question

Hi, i am trying to change this:

foreach $require (@Required) {

        # If the required field is the email field, the syntax of the email  #
        # address if checked to make sure it passes a valid syntax.          #
        if ($require eq 'email' && !&check_email($Config{$require})) {
            push(@error,$require);
        }

//////////////////////////////////////////////////////////////////////////////////

sub check_email {
    # Initialize local email variable with input to subroutine.              #
    $email = $_[0];

    # If the e-mail address contains:                                        #
    if ($email =~ /(@.*@)|(\.\.)|(@\.)|(\.@)|(^\.)/ ||

        # the e-mail address contains an invalid syntax.  Or, if the         #
        # syntax does not match the following regular expression pattern     #
        # it fails basic syntax verification.                                #

        $email !~ /^.+\@(\[?)[a-zA-Z0-9\-\.]+\.([a-zA-Z0-9]+)(\]?)$/) {

        # Basic syntax requires:  one or more characters before the @ sign,  #
        # followed by an optional '[', then any number of letters, numbers,  #
        # dashes or periods (valid domain/IP characters) ending in a period  #
        # and then 2 or 3 letters (for domain suffixes) or 1 to 3 numbers    #
        # (for IP addresses).  An ending bracket is also allowed as it is    #
        # valid syntax to have an email address like: user@[255.255.255.0]   #

        # Return a false value, since the e-mail address did not pass valid  #
        # syntax.                                                            #
        return 0;
    }

    else {

        # Return a true value, e-mail verification passed.                   #
        return 1;
    }
}

into this:

foreach $require (@Required) {


            if ($require eq 'fieldb' && !&check_fieldb($Config{$require})) {
                push(@error,$require);
            }

    ///////////////////////////////////////////////////////////////////////////////

    sub check_fieldb {

        # If field b is under 20% of field a:                                        #
        if ($fieldb <=($fielda/100)*20 ) {

            # Return a false value, since field b is less than 20% of field a
            return 0;
        }

        else {

            # Return a true value, fieldb verification passed.                   #
            return 1;
        }
    }

but it does not work, always returns as 0. how would i fix this?

Answer 1

It's impossible to be sure what's wrong without knowing the values of $fielda and $fieldb. My diagnosis is that $fieldb is less than or equal to ($fielda/100)*20

You pass a value to check_fieldb, but you never use it. Why do you pass it? As a commenter noted you should be passing to the function the values you want to check. Are $fielda and $fieldb guaranteed to be correctly initialized before check_fieldb is called?

Do you meant to be saying

foreach my $require (@Required){
    if($require eq 'fieldb' && !check_fieldb($value_of_fielda, $value_of_fieldb)){
        push(@error, $require);
    }
}

# ... later ...

sub check_fieldb($$){
    my $fielda = shift;
    my $fieldb = shift;

    return !($fieldb <=($fielda/100)*20);
}

perhaps?