ansaurus

Question

IE6 displays JavaScript error for below given function and error is also mentioned below..

Answer 1

+5 A:

Now what can i infer from this?

That there isn't an element with the id bannerid in the document.

David Dorward 2010-10-08 09:40:03

So how can i check for its existance before the assignment of value to that field,? Also other browsers do not display this error, I have this bannerid field as hidden field in the document... What should be done?

OM The Eternity 2010-10-08 09:44:59

`b = document.getElementById('bannerid');if(typeof b =='object'){b.value =n;}`

Kristoffer S Hansen 2010-10-08 09:46:51

It still throws me the error

OM The Eternity 2010-10-08 09:58:19

@David pls help me to get into the issue

OM The Eternity 2010-10-08 10:04:40

Kristoffer has already told you how to do that. Possibly your description of the problem has mistakes in it.

David Dorward 2010-10-08 10:13:25

Answer 2

A:

You just enable that hidden field and check whether that field has any value while browser's throws an error.

Mohan 2010-10-08 10:00:19

What do u mean by enabling the hidden field?

OM The Eternity 2010-10-08 10:04:00

Instead of using hidden field u plz try text field and check that has a value or not. This is not a solution, trying this u may get clear idea.

Mohan 2010-10-08 10:12:23

I did it and it still throws me the same error

OM The Eternity 2010-10-08 10:14:52

Answer 3

+2 A:

Rewrite as:

function setbid(catid) {
  var lookup = {
    '30' : 1,
    '31' : 2,
    '32' : 6
  };

  if (lookup.hasOwnProperty(catid)) {
    var el = document.getElementById('bannerid');

    if (el) {
      el.value = lookup[catid];
    }
  }
}

And make sure that there is an element with the id attribute exactly written as bannerid.

The function I give you is slightly different than yours:

using a lookup table to get values instead of if chains (especially if you will add values later)
doing the element lookup in only one part of the code instead of duplicating it
checking for the element's existence

EDIT for Update2:

Note directly relevant to your problem, but:

You should rather but your script tag in your <head> section
You should rather use progressive enhancement to react to events instead of mangling HTML and JavaScript code. Use event hooks instead.

Also check your the rendered page's source code to see if some elements were not eaten by the renderer because of a a malformation, or by your PHP code.

EDIT:

If I test with the following, it works perfectly fine:

<script>
function setbid(catid)
{
var lookup = {
    '30' : 1,
    '31' : 2,
    '32' : 6
  };

  if (lookup.hasOwnProperty(catid)) {
    var el = document.getElementById('bannerid');

    if (el) {
      el.value = lookup[catid];
      alert('done [' + el.value + ']');
    }
  }

}
</script>

<div style="margin:0px auto">
<div class="instantprice-popup-bg">
<form name="instantpop" id="instantpop" action="" method="post" style="margin:0px; padding:0px" onsubmit="">
    <input type="hidden" name="sessid" id="sessid" value="<?php echo $_GET['osCsid'];?>">
<div class="instantprice">

            <ul>
                <li class="text12pt" style="color:#FF0000; display:none;" id="appsize">For special low price on sizes over 30ft. wide and 10ft. height contact us on [email protected].</li>
                <li class="text12pt" style="color:#FF0000; display:none;" id="vinylsize">Please enter width upto 30 ft & height upto 5 ft for Vinyl Signs/Decals(Posters).</li>

                <li class="col1">Select Product</li>
                <li class="col2">

                    <input type="hidden" name="price" id="price" value="15" />
                    <input type="hidden" name="bannerid" id="bannerid" value="" />
                    <select name="product" class="dropdownfield" id="product" style="width: 180px;" onchange="javascript:setbid(document.getElementById('product').value);">
                    <option value="">Select Product</option>
                    <option value="1">1</option>
                    <option value="2">2</option>
                    <option value="3">3</option>
                    <option value="30">30</option>
                    <option value="31">31</option>
                    <option value="32">32</option>
                    </select></li>
            </ul>
            <input type="hidden" name="getpriceclick" value="1" />
        </div>
        </form>
</div>
</div>

So you have something screwing up your elements. I'd suspect something going wrong in your PHP code and producing a malformed output.

haylem 2010-10-08 10:16:09

Thanks Heylem, I tried ur way But it still throws me error, error displayed has been added as screen shot above...

OM The Eternity 2010-10-08 10:28:42

@OM The Eternity: OK. Are you sure it comes from that piece of code? And where do you put your code in your page? If you provided us with a more complete code snippet, we might be able to help more.

haylem 2010-10-08 10:31:56

Chk the Updated Question for code

OM The Eternity 2010-10-08 10:39:09

@OM The Eternity: As far as I can see the code seems fine. Can you post the full-page's code? Are elements really in this order (position of the script tag in the page, etc...)?

haylem 2010-10-08 10:51:05

@OM The Eternity: also, instead of the original source code, check the generated source as rendered in your browser see if the bannerid element is really here, as maybe you have a PHP error that prevent your element to be displayed and part of your code is not printed to the page.

haylem 2010-10-08 10:54:17

@Haylem thanx for the analysis , I have already checked the source code And I found the bannerid field in it, yes the form is as it is displayed above, I have just ommited the Mysql queries for the safety reasons

OM The Eternity 2010-10-08 10:57:40

@OM The Eternity: check my updated answer. So either something is wrong in your code and the output gets messed up OR the error is displayed by another piece of JavaScript.

haylem 2010-10-08 11:00:15

I have attempted all the stuffs a but i still get the error at the end, my bannerid field get desirable assigned value but as the script is ended the same error box is displayed.. i am facing this issue only in IE6 and IE7

OM The Eternity 2010-10-08 11:42:00

@OM The Eternity: if the value get set, then that document.getElementById error comes from somewhere else. You will have to use debug statements and try to figure out where it is. There's obviously some other JS code being run on your page.

haylem 2010-10-08 12:09:58

Answer 4

+1 A:

If the element does not exist on the DOM when this function is executed, the document.getElementById(...) will return null (or undefined).

Always best to use a script inspector (like FireBug or Safari console) while developing. If you must develop in IE6, you might want to inspect by incrementally "alert"ing.

Suggested debug output:

alert(document.getElementById);
alert(document.getElementById("bannerid"));
alert(document.getElementById("bannerid").value);

Oxyrubber 2010-10-08 10:16:33

Also, testing existence of elements can't be done against typeof(...) === "object" because... typeof(null) === "object". It's a controversial design decision, but the best way to avoid this is to test against null: if(typeof(el) !== null) {el.value = "foo";}

Oxyrubber 2010-10-08 11:00:19

Answer 5

A:

 <script type="text/javascript">
function notEmpty(){

    var myTextField = document.getElementById('myText');

    if(myTextField.value != "")
      {
        alert("You entered: " + myTextField.value)
            alert(document.getElementById('myText1').value=0);
      }
    else
        alert("Would you please enter some text?")      
}
</script>
<input type='text' id='myText' />
<input type='text' id='myText1' />
<input type='button' onclick='notEmpty()' value='click' />

Try this example

Mohan 2010-10-08 10:50:37

To debug the javascript function, just put the following statement as the first line of the function:alert("[" + bannerid + "]"); return false;This will display a bannerid value. If two empty brackets appear [] then you know the value passed was blank.

Mohan 2010-10-08 11:28:01

Mohan 2010-10-08 11:38:51

its works fine for me in firefox.

Mohan 2010-10-08 11:40:03

Yes It does work fine in FF problem is with IE6 and IE7

OM The Eternity 2010-10-08 11:43:51

ansaurus

tags:

views:

answers:

IE6 displays JavaScript error for below given function and error is also mentioned below..

related questions