Larger File Sizes are being incorrectly transfered with a NetworkStream

Question

I am transferring a file over a NetworkStream and it seems that when the file goes over about 5-10k, the file starts to miss out on data and/or have huge whitespace gaps.

Here is what I have:

private string ReadandSaveFileFromServer(TcpClient clientATF, NetworkStream currentStream, string locationToSave)
{
    int fileSize = 0;
    string fileName = "";
    int bytesRead = 0;

    fileName = ReadStringFromServer(clientATF, currentStream);
    fileSize = ReadIntFromServer(clientATF, currentStream);

    FileStream fs = new FileStream(locationToSave + "\\" + fileName, FileMode.Create);

    byte[] fileSent = new byte[fileSize];

    while (currentStream.DataAvailable)
    {
        if (clientATF.Connected)
        {
            bytesRead = currentStream.Read(fileSent, 0, fileSent.Length);
            fs.Write(fileSent, 0, fileSent.Length);
        }
        else
        {
            break;
        }
    }

    fs.Flush();
    fs.Close();

    return fileName;
}

Answer 1

No, you've written your buffer code wrong. At a first glance, I would recommend you change to fs.Write(fileSetn, 0, bytesRead) instead.

Answer 2

Here is the problem: fs.Write(fileSent, 0, fileSent.Length);

you write fileSent.Length bytes to file while you just got bytesRead bytes.

Corrected code:

fs.Write(fileSent, 0, bytesRead);

Answer 3

Get rid of the available test and read until you get EOS. That's a misuse of available.

Answer 4

Here is the answer. The fs.Write() error was an oversight on my part. Thanks for the help everyone.

  private string ReadandSaveFileFromServer(TcpClient clientATF, NetworkStream currentStream, string locationToSave)
    {
        int fileSize = 0;
        string fileName = "";
        int bytesRead = 0;

        fileName = ReadStringFromServer(clientATF, currentStream);
        fileSize = ReadIntFromServer(clientATF, currentStream);

        FileStream fs = new FileStream(locationToSave + "\\" + fileName, FileMode.Create);

        byte[] fileSent = new byte[fileSize];

        while (fs.Length != fileSize)
        {

                bytesRead = currentStream.Read(fileSent, 0, fileSent.Length);
                fs.Write(fileSent, 0, bytesRead);

        }

        fs.Flush();
        fs.Close();

        return fileName;
    }