Why doesn't this work? JavaScript

Question

It's a greasemonkey script. I don't know javascript so that makes this especially fun.

function notify(){
    if window.find("1 minute")==true{
        alert("y");
        setTimeout("alert('time to click soon!')",60000)
    }
    if window.find("2 minute")==true{
        alert("y");
        setTimeout("alert('time to click soon!')",2*60000)
    }

...repeated x30...

}
notify();

Thanks in advance.

Answer 1

You're missing parentheses around the if conditionals. They should look like:

if (window.find("1 minute")) {
    alert("y");
    setTimeout("alert('time to click soon!')",60000)
}

Also, no need to explicitly test against true; the if statement does that for you!

---

More things to make Douglas Crockford less angry with you

Don't pass strings into setTimeout. Pass functions. Like this:

setTimeout(function () {
    alert('time to click soon!');
}, 60000);

or like this (even better, since you're reusing the function):

function showAlert() {
    alert('time to click soon!');
}

// later...

setTimeout(showAlert, 60000);

Answer 2

Also, I think you should probably be using unsafeWindow.