Firefox doesn't know what to do when something null appears while building a URL

Question

Hi

I am facing an issue here as shown in code is mentioned below

Inside the function I have something like this

AJAXRequest("getActivityEntries?orgEntry="+orgentryid+"&activity_entry="+activity_entry+"&target=AJAX");

if orgentryid is null here,

After building the HTML page, the JAVAScript looks like…

AJAXRequest("getActivityEntries?orgEntry="++"&activity_entry="+$activity_entry+"&target=AJAX");

Firefox throws and exception with ++ being used with Strings.

Then we added If/Else checks for the existence of orgentryid…

if(activity_entry && "activity_entry" != " ")
            if (orgentryid)
                    AJAXRequest("getActivityEntries?orgEntry="+orgentryid+"&activity_entry="+activity_entry+"&target=AJAX");
                else
                    AJAXRequest("getActivityEntries?activity_entry="+activity_entry+"&target=AJAX");

        else
          if (orgentryid)
             AJAXRequest("getActivityEntries?orgEntry="+!orgentryid+"&target=AJAX");
           else
             AJAXRequest("getActivityEntries?target=AJAX");

But since then performance has taken a beating. Is there anything can be done with Firefox.

Answer 1

Have you tried something like this ?

AJAXRequest("getActivityEntries?orgEntry="+(orgentryid||"")+"&activity_entry="+(activity_entry||"")+"&target=AJAX");

Answer 2

Pragmatic without ternary operators - assuming strings and not 0's in the vars

var URL = "getActivityEntries?target=AJAX"; 
if (activity_entry) URL += "&activity_entry="+activity_entry;
if (orgentryid)     URL += "&orgEntry="+orgentryid;
AJAXRequest(URL);