views:

47

answers:

4

Given the following JavaScript:

var someFunction = function(id) {
  //do some stuff
  var modifyId = function(id) {
     //do some stuff
     outer.id = id; //is there any way to modify the id variable in the outer scope from here?
  }
}

How do you modify the id passed into the outer function scope from within the inner function scope?

+1  A: 

Why can't you just rename one of the variables?

Adam Byrtek
+4  A: 

Unfortunately you can't. By naming the parameter in the nested function id, you've shadowed the parameter in the outer function. Javascript contains no facility for accessing the shadowed name. The only option is to choose a different name for one of the variables.

JaredPar
+2  A: 

No, there isn't. From within a function, there's no way (something weird in Mozilla's code or ES5 aside) to refer to the scope as a context in any explicit way, and there's no way to climb up the lexical scope chain in any direct way.

Good question though.

Pointy
+1  A: 
var someFunction = function(id) {
  //do some stuff
  var oid = id;
  var modifyId = function(id) {
     //do some stuff
     // you can access the outer id via the oid variable
  }
}

But, yes, you should just rename one of the formal parameters.

Šime Vidas
At first I thought this worked, but it won't work if id is a primitive. Setting `oid = "BLAH"` from the inner function will not change the value of id. If it were an object, both id and oid would point to the same object, which is almost the effect you want (you still couldn't change what object id points to by calling `oid = {a:1}`
Juan Mendes
@Juan Yes. Since id is a string (I assume), that means that my work-around is pretty much useless in this case. So the only solution remains to avoid formal parameters with the same names in nested functions.
Šime Vidas