tags:

views:

323

answers:

4

I was reading about threading and about locking. It is common practise that you can't (well should not) lock a value type.

So the question is, what is the recommended way of locking a value type? I know there's a few ways to go about doing one thing but I haven't seen an example. Although there was a good thread on MSDN forums but I can't seem to find that now.

Thanks

+6  A: 

Use another object for the lock.

int valueType;
object valueTypeLock = new object();

void Foo()
{
    lock (valueTypeLock)
    {
        valueType = 0;
    }
}
Jon B
Remember to make the lock object readonly, or it can be changed to a different object. The shared lock assumption can go out of the window in this case.
chibacity
+1  A: 

Depend on your situation you might be able to avoid using locks by leveraging System.Threading.Interlocked the same code in Jon's example becomes:

System.Threading.Interlocked.Exchange(valueType,0)

JoshBerke
+3  A: 

Your question is worded in such a way that it suggests to me that you don't entirely understand locking. You don't lock the data, you lock to protect the integrity of the data. The object you lock on is inconsequential. What matters is that you lock on the same object in other areas of your code that alter the data being protected.

HTH, Kent

Kent Boogaart
Good distinction
JoshBerke
Well explained.
Charles Prakash Dasari
A: 

I'm always using a separate variable to lock on:

object syncObj = new object();

void Foo()
{
  lock(syncObj)
  {
    // do some stuff
  }
}

Locking on value-types doesn't make sense anyway because value-types are immutable and can't be modified. Locking on 'this' is also problematic because 'this' is visible to the outer world.

For some information about how the Monitor was originally intended to be used see Monitor (synchronization)

Thomas Danecker
Err, value-type objects aren't really immutable. When I say int i=0; ++i; I've just modified a value-type object.
Andreas Huber
no, you assigned a new value to the variable, but you didn't mutate the value-type. value-types are 'values'. 1 is always 1. 1+1 is the value 2 but you don't change the value 1 to 2.you could modify composite value-types (aka structs) though that's also considered as (very) bad practice.
Thomas Danecker