ansaurus

Question

How would you refactor page members out of ASPX code?

Answer 1

+1 A:

In the normal case if two users load the page at the same time they will be using different instances of the page. As numberOne and numberTwo are instance variables there will be no shared state and no threading problem.

Brownie 2009-01-08 02:14:33

Answer 2

+3 A:

This code is ok. The member variables are instantiated every time the page loads, as a new instance of a class is created on every page load. If the variables were static, only then would you have problems with 2 people loading the page at the same moment.

Think about the controls you drop on a page. They are member variables, but they don't have problem with the page being loaded at the same time by different requests.

Paul Whitehurst 2009-01-08 02:16:35

Thank you. I completely misunderstood the ASPX render cycle. This clarifies much.

Ryan Michela 2009-01-08 04:08:48

Answer 3

A:

Whilst there isnt really anyhting wrong with the code (as already mentioned) if you wanted to refactor it, I'd probably do something along the lines of

using System; using System.Web;

namespace BadPassing
{
    public partial class _Default : System.Web.UI.Page
    {
        private Random rnd = new Random(); //Is this bad?

        protected int numberOne; //this is bad
        protected int numberTwo; //this is bad

        protected void Page_Load(object sender, EventArgs e)
        {
            numberOne = rnd.Next(100);
            numberTwo = rnd.Next(100);
            searchLink.NavigationUrl = String.Format("http://www.google.com/search?q={0}%2B{1}", numberOne, numberTwo);
            searchLink.Text = String.Format("Add {0} and {1} using google", numberOne, numberTwo);
        }
    }
}

and then on your aspx page just add an <asp:hyperlink> control

lomaxx 2009-01-08 03:06:29

ansaurus

tags:

views:

answers:

How would you refactor page members out of ASPX code?

related questions