views:

12536

answers:

9

I have a service written in C# (.NET 1.1) and want it to perform some cleanup actions at midnight every night. I have to keep all code contained within the service, so what's the easiest way to accomplish this? Use of Thread.Sleep() and checking for the time rolling over?

+3  A: 

The way I accomplish this is with a timer.

Run a server timer, have it check the Hour/Minute every 60 seconds.

If it's the right Hour/Minute, then run your process.

I actually have this abstracted out into a base class I call OnceADayRunner.

Let me clean up the code a bit and I'll post it here.

 private void OnceADayRunnerTimer_Elapsed(object sender, ElapsedEventArgs e)
 {
  using (NDC.Push(GetType().Name))
  {
   try
   {
    log.DebugFormat("Checking if it's time to process at: {0}", e.SignalTime);
    log.DebugFormat("IsTestMode: {0}", IsTestMode);

    if ((e.SignalTime.Minute == MinuteToCheck && e.SignalTime.Hour == HourToCheck) || IsTestMode)
    {
     log.InfoFormat("Processing at: Hour = {0} - Minute = {1}", e.SignalTime.Hour, e.SignalTime.Minute);
     OnceADayTimer.Enabled = false;
     OnceADayMethod();
     OnceADayTimer.Enabled = true;

     IsTestMode = false;
    }
    else
    {
     log.DebugFormat("Not correct time at: Hour = {0} - Minute = {1}", e.SignalTime.Hour, e.SignalTime.Minute);
    }
   }
   catch (Exception ex)
   {
    OnceADayTimer.Enabled = true;
    log.Error(ex.ToString());
   }

   OnceADayTimer.Start();
  }
 }

The beef of the method is in the e.SignalTime.Minute/Hour check.

There are hooks in there for testing, etc. but this is what your elapsed timer could look like to make it all work.

CubanX
A slight delay due to a busy server could cause it to miss the hour+minute.
Jon B
True. When I did this, I checked : Is the time now greater than 00:00? If so, is it more than 24 hours since I last ran the job? If so, run the job, otherwise wait again.
ZombieSheep
+6  A: 

Does it have to be an actual service? Can you just use the built in scheduled tasks in the windows control panel.

Ian Jacobs
Since the service already exists, it might be easier to add the functionality there.
M4N
Converting a narrow purpose service such as this into a console app should be trivial.
Stephen Martin
He already said, "I have to keep all code contained within the service". I don't feel it is necessary to question the original requirements. It depends, but sometimes there are very good reasons to use a service over a scheduled task.
jeremcc
+1: Because you allways need to look at your problems from all sides.
GvS
Jerry: Perhaps, but requiring Yet Another Idle Background App on someone's computer, especially a .NET Managed app, is not cool. MAYBE if it was a C native app that, while idle, used almost no memory, but this sounds different. :)
Robert P
It depends on how many background tasks you have to manage. My current project has about 9 different jobs it perform under various schedules, and I run them all within a single windows service using Quartz.NET to do the scheduling.
jeremcc
If I truly had only *one* task to run per day, then I guess a simple console app run with a scheduled task would be fine. My point is that it all depends on the situation, and saying "Don't use a windows service" is not a useful answer IMO.
jeremcc
A: 

i would suggest you move to .net 2.0 more have 2.0 than 1.1 any way... you can have the code in a class lib and use it from with in the service this way you could port it to a console application in a fast and easy manner..

Petoj
+4  A: 

A daily task? Sounds like it should just be a scheduled task (control panel) - no need for a service here.

Marc Gravell
+13  A: 

Check out Quartz.NET. You can use it within a Windows service. It allows you to run a job based on a configured schedule, and it even supports a simple "cron job" syntax. I've had a lot of success with it.

Here's a quick example of its usage:

// Instantiate the Quartz.NET scheduler
var schedulerFactory = new StdSchedulerFactory();
var scheduler = schedulerFactory.GetScheduler();

// Instantiate the JobDetail object passing in the type of your
// custom job class. Your class merely needs to implement a simple
// interface with a single method called "Execute".
var job = new JobDetail("job1", "group1", typeof(MyJobClass));

// Instantiate a trigger using the basic cron syntax.
// This tells it to run at 1AM every Monday - Friday.
var trigger = new CronTrigger(
    "trigger1", "group1", "job1", "group1", "0 0 1 ? * MON-FRI");

// Add the job to the scheduler
scheduler.AddJob(job, true);
scheduler.ScheduleJob(trigger);
jeremcc
A good suggestion - as soon as you do something even slightly more complex than the basic Timer stuff you should look at Quartz.
serg10
Quartz is so easy to use, I'd argue that even for a super-simple task, just go ahead and use it. It will give the ability to easily adjust the scheduling.
Andy White
A: 

You probably want to use a Timer Object. See the details here for using one in a service.

plinth
+7  A: 

I wouldn't use Thread.Sleep(). Either use a scheduled task (as others have mentioned), or set up a timer inside your service, which fires periodically (every 10 minutes for example) and check if the date changed since the last run:

private Timer _timer;
private DateTime _lastRun = DateTime.Now;

protected override void OnStart(string[] args)
{
    _timer = new Timer(10 * 60 * 1000);
    _timer.Elapsed += new System.Timers.ElapsedEventHandler(timer_Elapsed);
    //...
}


private void timer_Elapsed(object sender, System.Timers.ElapsedEventArgs e)
{
    // ignore the time, just compare the date
    if (_lastRun.Date < DateTime.Now.Date)
    {
     // stop the timer while we are running the cleanup task
     _timer.Stop();
     //
     // do cleanup stuff
     //
     _lastRun = DateTime.Now;
     _timer.Start();
    }
}
M4N
Wouldn't it make more sense to just set the timer to expire at midnight, instead of waking up every minute to check the time?
Kibbee
A: 

I would suggest that you use a timer, but set it to check every 45 seconds, not minute. Otherwise you can run into situations where with heavy load, the check for a particular minute is missed, because between the time the timer triggers and the time your code runs and checks the current time, you might have missed the target minute.

GWLlosa
If you're not checking to ensure that it hasn't already run once, there's the potential that you could hit 00:00 twice if you're checking ever 45 seconds.
Michael Meadows
Good Point. This problem could be avoided by calling Sleep(15000) at the end of the checking procedure. (or perhaps 16000 ms, just to be on the safe side ;-)
Treb
I agree, you should check if it's already run, regardless of what timer duration you pick.
GWLlosa
A: 

As others already wrote, a timer is the best option in the scenario you described.

Depending on your exact requirements, checking the current time every minute may not be necessary. If you do not need to perform the action exactly at midnight, but just within one hour after midnight, you can go for Martin's approach of only checking if the date has changed.

If the reason you want to perform your action at midnight is that you expect a low workload on your computer, better take care: The same assumption is often made by others, and suddenly you have 100 cleanup actions kicking off between 0:00 and 0:01 a.m.

In that case you should consider starting your cleanup at a different time. I usually do those things not at clock hour, but at half hours (1.30 a.m. being my personal preference)

Treb