views:

1631

answers:

3

I have a Visual Studio setup project that has an Installer class. In the installer class I set a setting as follows:

       MessageBox.Show(Properties.Settings.Default.MySetting);

        Properties.Settings.Default.MySetting = "Foo";
        Properties.Settings.Default.Save();

        MessageBox.Show(Properties.Settings.Default.MySetting);

The problem is that even though I know that this code is being executed (I am doing other stuff), the setting is never set!!

The message boxes do suggest that the value is being set, but when I go to the .config file the value is still blank!

Anyone have any ideas why and/or a possible workaround?

A: 

I honestly don't know if this is supported during an installer - but my first question would be: are you calling Save() on Settings.Default?

Marc Gravell
I have set the Save setting, but despite this the value isn't really being set!
Calanus
A: 

Well in the end I gave up and had a RunOnce type of method to do this stuff after the app was installed.

Calanus
+1  A: 

What I do for my installers is to use the "file" attribute in App.Config. The appSettings block takes a "file" attribute, like so:

<appSettings file="user.config">
    <add key="foo" value="some value unchanged by setup"/>
</appSettings>

The "file" attribute is sort of like CSS, in that the most specific setting wins. If you have "foo" defined in user.config as well as App.config, the value in user.config is used.

Then, I have a config generator that writes out a second appSettings block to user.config (or whatever you want to call it), using values in a dictionary.

using System.Collections.Generic;
using System.Text;
using System.Xml;

namespace Utils
{
    public class ConfigGenerator
    {
        public static void WriteExternalAppConfig(string configFilePath, IDictionary<string, string> userConfiguration)
        {
            using (XmlTextWriter xw = new XmlTextWriter(configFilePath, Encoding.UTF8))
            {
                xw.Formatting = Formatting.Indented;
                xw.Indentation = 4;
                xw.WriteStartDocument();
                xw.WriteStartElement("appSettings");

                foreach (KeyValuePair<string, string> pair in userConfiguration)
                {
                    xw.WriteStartElement("add");
                    xw.WriteAttributeString("key", pair.Key);
                    xw.WriteAttributeString("value", pair.Value);
                    xw.WriteEndElement();
                }

                xw.WriteEndElement();
                xw.WriteEndDocument();
            }
        }
    }
}

In your installer, just add something like the following in your Install method:

string configFilePath = string.Format("{0}{1}User.config", targetDir, Path.DirectorySeparatorChar);

IDictionary<string, string> userConfiguration = new Dictionary<string, string>();

userConfiguration["Server"] = Context.Parameters["Server"];
userConfiguration["Port"] = Context.Parameters["Port"];

ConfigGenerator.WriteExternalAppConfig(configFilePath, userConfiguration);

We use it for our test, training, and production servers, so all we have to do is specify the machine name and password during the install, and everything's taken care of for us. It used to be a 3-hour process, including going through multiple config files to set passwords. Now it's almost entirely automated.

Hope this helps.

Chris Doggett
Thanks for this, it looks like the kind of solution I'm after. Although I hit a problem, if I override the Install method in my installer, the values from the custom UI are not in the context parameters. Am I using the right method? Cheers
MrEdmundo
Ignore that, I hadn't passed the data from the UI in the CustomActions editing screen.
MrEdmundo