ansaurus

Question

Make this function defensible against null/empty strings etc.

Answer 1

+7 A:

function getSecondPart(str) {
    if(str === undefined ||
       typeof str != 'string' ||
       str.indexOf('-') == -1) return false;
    return str.split('-')[1];
}
console.log(getSecondPart({}); // false
console.log(getSecondPart([]); // false
console.log(getSecondPart()); // false
console.log(getSecondPart('')); // false
console.log(getSecondPart('test')); // false
console.log(getSecondPart('asdf-test')); // test

Paolo Bergantino 2009-02-21 18:58:30

That's about as defensive as it's gonna get :x

Paolo Bergantino 2009-02-21 19:03:33

Don’t make it too complicated.

Gumbo 2009-02-21 19:05:53

Yeah. I simpled it up a bit.

Paolo Bergantino 2009-02-21 19:06:21

Oh, so you like my proposal …

Gumbo 2009-02-21 19:10:35

Haha, I thought of it before seeing yours, but I'll give you an upvote if it'll make ya feel better :)

Paolo Bergantino 2009-02-21 19:14:08

You should switch != for !== on line 3 and == for === on line 4.

Kit Sunde 2009-02-21 20:15:56

Use "typeof str === 'undefined'" instead since "undefined" is just a global variable that can be overwritten (undefined="a string"). Also use "!==" on line 3 and "< 0" or "=== -1" on line 4.

some 2009-02-22 02:32:02

Answer 2

+1 A:

I’d say:

function getSecondPart(str) {
    if (typeof str !== "string" || str.indexOf("-") === -1) return false;
    return str.split("-")[1];
}

Gumbo 2009-02-21 19:04:03

ansaurus

tags:

views:

answers:

Make this function defensible against null/empty strings etc.

related questions