tags:

views:

209

answers:

8

How could I set a constraint on a table so that only one of the records has its isDefault bit field set to 1?

The constraint is not table scope, but one default per set of rows, specified by a FormID.

+3  A: 

From a normalization perspective, this would be an inefficient way of storing a single fact.

I would opt to hold this information at a higher level, by storing (in a different table) a foreign key to the identifier of the row which is considered to be the default.

CREATE TABLE [dbo].[Foo](
    [Id] [int] NOT NULL,
 CONSTRAINT [PK_Foo] PRIMARY KEY CLUSTERED 
(
    [Id] ASC
) ON [PRIMARY]
) ON [PRIMARY]

GO

CREATE TABLE [dbo].[DefaultSettings](
    [DefaultFoo] [int] NULL
) ON [PRIMARY]

GO

ALTER TABLE [dbo].[DefaultSettings]  WITH CHECK ADD  CONSTRAINT [FK_DefaultSettings_Foo] FOREIGN KEY([DefaultFoo])
REFERENCES [dbo].[Foo] ([Id])
GO

ALTER TABLE [dbo].[DefaultSettings] CHECK CONSTRAINT [FK_DefaultSettings_Foo]
GO
Ian Nelson
This method will not ensure that only one row has isDefault = 1
Andy Jones
@Andy Jones, you're right, it won't. I wouldn't have an isDefault column at all. I'm suggesting an alternative solution.
Ian Nelson
Yes, but this alternative solution still allows for multiple defaults by inserting many rows into dbo.DefaultSettings. Could maybe add a trigger to dbo.DefaultSettings to only allow 1 row in there if you chose that method.
Andy Jones
@Andy Jones - true, good point.
Ian Nelson
A: 

You could do it through an instead of trigger, or if you want it as a constraint create a constraint that references a function that checks for a row that has the default set to 1

EDIT oops, needs to be <=

Create table mytable(id1 int, defaultX bit not null default(0))
go

create Function dbo.fx_DefaultExists()
returns int as 
Begin
    Declare @Ret int
    Set @ret = 0
    Select @ret = count(1) from mytable 
    Where defaultX = 1

    Return @ret
End
GO
Alter table mytable add
CONSTRAINT  [CHK_DEFAULT_SET] CHECK 
 (([dbo].fx_DefaultExists()<=(1)))
GO
Insert into mytable (id1, defaultX) values (1,1)

Insert into mytable (id1, defaultX) values (2,1)
cmsjr
+2  A: 

You could use an insert/update trigger.

Within the trigger after an insert or update, if the count of rows with isDefault = 1 is more than 1, then rollback the transaction.

Andy Jones
+1  A: 

I don't know about SQLServer.But if it supports Function-Based Indexes like in Oracle, I hope this can be translated, if not, sorry.

You can do an index like this on suposed that default value is 1234, the column is DEFAULT_COLUMN and ID_COLUMN is the primary key:

CREATE UNIQUE INDEX only_one_default on (DECODE(DEFAULT_COLUMN, 1234, -1, ID_COLUMN))

This sentence create an unique index indexing -1 if the value of DEFAULT_COLUMN is 1234 and ID_COLUMN in any other case. Then, if two columns have DEFAULT_COLUMN value, it crashes.

FerranB
A: 

This is a fairly complex process that cannot be handled through a simple constraint.

We do this through a trigger. However before you write the trigger you need to be able to answer several things:

do we want to fail the insert if a default exists, change it to 0 instead of 1 or change the existing default to 0 and leave this one as 1? what do we want to do if the default record is deleted and other non default records are still there? Do we make one the default, if so how do we determine which one?

You will also need to be very, very careful to make the trigger handle multiple row processing. For instance a client might decide that all of the records of a particular type should be the default. You wouldn't change a million records one at a time, so this trigger needs to be able to handle that. It also needs to handle that without looping or the use of a cursor (you really don't want the type of transaction discussed above to take hours locking up the table the whole time).

You also need a very extensive tesing scenario for this trigger before it goes live. You need to test: adding a record with no default and it is the first record for that customer adding a record with a default and it is the first record for that customer adding a record with no default and it is the not the first record for that customer adding a record with a default and it is the not the first record for that customer Updating a record to have the default when no other record has it (assuming you don't require one record to always be set as the deafault) Updating a record to remove the default Deleting the record with the deafult Deleting a record without the default Performing a mass insert with multiple situations in the data including two records which both have isdefault set to 1 and all of the situations tested when running individual record inserts Performing a mass update with multiple situations in the data including two records which both have isdefault set to 1 and all of the situations tested when running individual record updates Performing a mass delete with multiple situations in the data including two records which both have isdefault set to 1 and all of the situations tested when running individual record deletes

HLGEM
+1  A: 
CREATE VIEW vOnlyOneDefault
AS
  SELECT 1 as Lock
  FROM <underlying table>
  WHERE Default = 1
GO
CREATE UNIQUE CLUSTERED INDEX IX_vOnlyOneDefault on vOnlyOneDefault (Lock)
GO

You'll need to have the right ANSI settings turned on for this.

Damien_The_Unbeliever
This looks good, but complicated. I'd have to build the `create view` statement dynamically, as the default constraint isn't table wide, it's per FormID in the underlying table.
ProfK
When you have a complicated problem, you will need a complicated solution. This will not address all the other problems I mentioned about how you want to handle things as data changes.
HLGEM
Also remember to use WITH SCHEMABINDING when creating the view
kristof
A: 

@Andy Jones gave an answer above closest to mine, but bearing in mind the Rule of Three, I placed the logic directly in the stored proc that updates this table. This was my simple solution. If I need to update the table from elsewhere, I will move the logic to a trigger. The one default rule applies to each set of records specified by a FormID and a ConfigID:

ALTER proc [dbo].[cpForm_UpdateLinkedReport]
 @reportLinkId int,
 @defaultYN bit,
 @linkName nvarchar(150)
as
if @defaultYN = 1
begin
 declare @formId int, @configId int
 select @formId = FormID, @configId = ConfigID from csReportLink where ReportLinkID = @reportLinkId
 update csReportLink set DefaultYN = 0 where isnull(ConfigID,  @configId) = @configId and FormID = @formId
end
update
 csReportLink
 set
 DefaultYN = @defaultYN,
 LinkName = @linkName
where
 ReportLinkID = @reportLinkId
ProfK
ALways a bad idea to put required logic in a stored proc vice a trigger. You won't always know when you need to change to a trigger later because multiple applications are using this. You are creating a data integrity nightmare for some future person to fix.
HLGEM
I'm responsible for the single application area that maintains that table, and we release tomorrow, so not having to add to our SQL update script reduces risk. The update script for sp's is generated, other objects it's manual, with risk.I will schedule a trigger for next cycle, in 6 weeks time.
ProfK
+1  A: 

Here's a modification of Damien_The_Unbeliever's solution that allows one default per FormID.

CREATE VIEW form_defaults
AS
SELECT FormID
FROM whatever
WHERE isDefault = 1
GO
CREATE UNIQUE CLUSTERED INDEX ix_form_defaults on is_form_defaults (FormID)
GO

But the serious relational folks will tell you this information should just be in another table.

CREATE TABLE form
FormID int NOT NULL PRIMARY KEY
DefaultWhateverID int FOREIGN KEY REFERENCES Whatever(ID)
Tom Future