views:

1987

answers:

6

Amazon.com recently updated their javascript, and it's causing problems with some Opera browsers.

Their browser detection code looks like so, but it's faulty:

    function sitbReaderIsCompatibleBrowser() {
        if (typeof(jQuery) == 'undefined') {
            return false;
        } else {
            var version = jQuery.browser.version || "0";
            var splitVersion = version.split('.');
            return (
                   (jQuery.browser.msie && splitVersion[0] >= 6)  // IE 6 and higher
                || (jQuery.browser.mozilla && (
                       (splitVersion[0] == 1 && splitVersion[1] >= 8) // Firefox 2 and higher
                    || (splitVersion[0] >= 2)
                   ))
                || (jQuery.browser.safari && splitVersion[0] >= 500) // Safari 5 and higher
                || (jQuery.browser.opera && splitVersion[0] >= 9) // Opera 5 and higher
            );
        }
}

Nothing obviously wrong jumps out at me with this code, but I've never used jQuery before so I don't know.

Even though this code looks like it's attempting to let Opera users through, when I visit the page with Opera 9.64 I get an "unsupported browser" message. If I change Opera's settings to report itself as Firefox, the page works perfectly! With that in mind, I'm pretty sure it's a problem with the script and not the browser.

Any jQuery experts have a suggestion?

You can replicate the behavior by visiting any book on Amazon and clicking the "look inside this book" link.

+1  A: 

I check for Opera like this:

if (/Opera/.test (navigator.userAgent)) // do something

Why would you want jQuery?

Ilya Birman
I don't--it's Amazon. I wrote their tech support, but as usual the folks at tech support had never heard of javascript. Aargh. I figure it's more productive to send them a fix than ask for help, since a fix might actually get forwarded to a programmer instead of a CSR.
Ahh, the best thing any web developer can do is to stop detecting browsers whatsoever :-)
Ilya Birman
A: 

I don't know for sure ( i never really check for opera anyway) but if the built-in jQuery functionality doesn't detect opera, may be a bug with the jQuery which needs to be fixed. I would suspect if that's the case, it should get resolved fairly quickly.

Roy Rico
jQuery says it's Opera compatible, and the example page at http://docs.jquery.com/Utilities/jQuery.browser detects my browser perfectly. I don't think it's a jQuery bug. It has to be something about the way they are using it.
+3  A: 

It is much better to detect javascript capabilities rather than browser userAgent.

ie DOM, XmlHttpRequest, eventing model (event.target vs event.srcElement), ActiveX, Java etc

By focusing on the API functions that you will require, rather than a target browser you will create a more robust set of scripts, and inevitably less special casing.

This link here at opera will probably tell you more

Xian
+9  A: 

Prior to jQuery 1.3, you could use jQuery.browser:

if( $.browser.opera ){
  alert( "You're using Opera version "+$.browser.version+"!" );
}

From version 1.3, you should use jQuery.support instead.

Main reason for this is that should should avoid checking for browsers, as features may change from version to version, making your code obsolete in no time.

You should always try to use feature detection instead. This will allow you to see if current browser supports the feature you're trying to use, regardless the browser brand, version, etc.

Seb
Spot-on. That's the code I'm looking for. Now hopefully Amazon will listen... :)
Glad to help, Lista. Could you please mark as solved if this helped you? Thanks!
Seb
+1  A: 

There is a special window.opera object which is present in all Opera 5+ browsers. So something as simple as:

if (window.opera) { // we are in Opera }

would be enough.

jayarjo
A: 

In current HTML5 times, you can also check for browser features instead often.

if (!window.FormData) { alert("xmlhttprequest L2 FormData interface not available"); }
sinni800