Compression HTTP Module that can escape inline scripts

Question

I have HTTP module that compresses HTTP request.

public override void Write(byte[] buffer, int offset, int count)
{
    byte[] data = new byte[count];
    Buffer.BlockCopy(buffer, offset, data, 0, count);
    string html = System.Text.Encoding.Default.GetString(buffer);

    Regex reg = new Regex(@"(?<=[^])\t{2,}|(?<=[>])\s{2,}(?=[<])|(?<=[>])\s{2,11}(?=[<])|(?=[\n])\s{2,}");
    html = reg.Replace(html, string.Empty);

    byte[] outdata = System.Text.Encoding.Default.GetBytes(html);
    _sink.Write(outdata, 0, outdata.GetLength(0));
}

How can I escape all inline scripts? This is my scripts regex.

Regex reg = new Regex("<script[^>]*?>[\\w|\\t|\\r|\\W]*?</script>", (RegexOptions.Singleline | RegexOptions.IgnoreCase));

Answer 1

I really doubt that you want to be using Encoding.Default, which is specific to your system. Aside from that, why not use the more standard way of doing compression, namely gzip the binary data instead of doing text manipulation? I suspect that will have more impact, and isn't nearly as fragile in terms of accidentally breaking the HTML. In addition, you won't need to worry about the encoding any more.