C#: Accessing form members from another class

Question

Hello,

The point is to notify the user using the memo when a packet is received/sent in a TCP Client. The old code was extra dumb,I used a Timer that used to add text in the memo since the Timer has access to the form members,lol.

The old code:

//Memo.Text += txt + "\n";

I played with it today,this is what I've done

In Form1's class

public string TextValue
{
    get
    {
        return Memo.Text;
    }

    set
    {
        this.Memo.Text += value + "\n";
    }
}

I call the code like that:

Form1 myForm = new Form1();
myForm.TextValue = "test asdasd";

The memo modifiers are private,but that's not the problem.

The problem is that no text is displayed on the memo when i call the code.

Answer 1

By typing this:

Form1 myForm = new Form1();

you create a new instance of your form (Form1), but instead I guess you should use existing instance which most likely has been initialized already.

One of the ways to do it:

var form = Form.ActiveForm as Form1;

if (form != null)
{
     form.TextValue = "test asdasd";
}

Though this is not very good design. Try to use custom events instead.

Answer 2

Maybe you should consider publishing an event in your tcpclient. Then your form will be able to listen to this event and display proper information.