views:

1176

answers:

7

Can anyone explain why the following doesn't compile?

byte b = 255 << 1

The error:

Constant value '510' cannot be converted to a 'byte'

I'm expecting the following in binary:

1111 1110

The type conversion has stumped me.

+1  A: 
255 << 1

will give you more than one byte.

Otávio Décio
+1  A: 

have you tried casting it?

byte b = (byte)(255 << 1)


This is an interesting approach - the above code will work if wrapped in a unchecked block like this:

unchecked
{
    byte b = (byte)(255 << 1);
}

Since it is unchecked the value is truncated to the intended value of 254. So it is possible to do this with a cast!

Daniel A. White
-1 You can't cast, it won't even compile.
Andrew Hare
Maybe you mean (byte)(255 << 1) ?
finnw
try: byte b = (255 << 1)
Joel Potter
Joel is correct - see Michael Burr's answer.
Andrew Hare
casting is not the solution to everything ;)
PoweRoy
I removed my (-1) as this will work if wrapped in "unchecked".
Andrew Hare
+6  A: 

You are shifting 255 by 1 bit, then trying to assign it to a byte. 255 << 1 is 510, and 510 won't fit in to a byte.

Steve Haigh
+16  A: 

Numeric literals in C# are int, not byte (and the bit shift will be evaluated by the compiler, hence only the 510 remains). You are therefore trying to assign a value to a byte which does not fit. You can mask with 255:

byte b = (255 << 1) & 0xFF

to reduce the result to 8 bits again. Unlike Java, C# does not allow overflows to go by undetected. Basically you'd have two sensible options when trying to assign 510 to a byte: Either clamp at the maximum value, then you'd get 255, or throw away the bits that do not fit, in which case you'd get 254.

You can also use unchecked, as lassevk mentioned:

byte b = unchecked((byte)(255 << 1));
Joey
Not sure why I thought 255 would be stored as a 8 bit
Chris S
Well, 255 fits, everything above doesn't :)
Joey
It should be noted, as I was pushed here from another thread, that even if you have two bytes, any bitwise operation on them will return an int.
blesh
Silly question, why do you use a hex representation of 255 instead of just using 255?
Sir Psycho
@Sir: Habit when using numbers as bitmasks. If you're `and` -ing or `or` -ing with a number you don't care about its decimal representation; you want to see immediately what bits are set and which are not.
Joey
+3  A: 
byte b = 0xff & (255 << 1);
Michael Burr
+3  A: 

The result of the << operator is an Int32, not what you put into it.

You need to cast the result of the shift, not the input. Additionally, it will produce an overflow (it is larger than a byte afterall), so you need to specify that you need an unchecked cast.

In other words, this will work:

Byte b = unchecked((Byte)(255 < 1));
Lasse V. Karlsen
A: 

And since << has a higher precedence than & you can save the brackets:

byte b = 255 << 1 & 0xff;
sipwiz