views:

4356

answers:

4

I would like to pass a parameter defined in the XAML (View) of my application to the ViewModel class by using the RelayCommand. I followed Josh Smith's excellent article on MVVM and have implemented the following.

XAML Code

        <Button 
        Command="{Binding Path=ACommandWithAParameter}"
        CommandParameter="Orange"
        HorizontalAlignment="Left" 
        Style="{DynamicResource SimpleButton}" 
        VerticalAlignment="Top" 
        Content="Button"/>

ViewModel Code

  public RelayCommand _aCommandWithAParameter;
  /// <summary>
  /// Returns a command with a parameter
  /// </summary>
  public RelayCommand ACommandWithAParameter
  {
     get
     {
        if (_aCommandWithAParameter == null)
        {
           _aCommandWithAParameter = new RelayCommand(
               param => this.CommandWithAParameter("Apple")
               );
        }

        return _aCommandWithAParameter;
     }
  }

  public void CommandWithAParameter(String aParameter)
  {
     String theParameter = aParameter;
  }
  #endregion

I set a breakpoint in the CommandWithAParameter method and observed that aParameter was set to "Apple", and not "Orange". This seems obvious as the method CommandWithAParameter is being called with the literal String "Apple".

However, looking up the execution stack, I can see that "Orange", the CommandParameter I set in the XAML is the parameter value for RelayCommand implemenation of the ICommand Execute interface method.

That is the value of parameter in the method below of the execution stack is "Orange",

  public void Execute(object parameter)
  {
     _execute(parameter);
  }

What I am trying to figure out is how to create the RelayCommand ACommandWithAParameter property such that it can call the CommandWithAParameter method with the CommandParameter "Orange" defined in the XAML.

Is there a way to do this?

Why do I want to do this? Part of "On The Fly Localization" In my particular implementation I want to create a SetLanguage RelayCommand that can be bound to multiple buttons. I would like to pass the two character language identifier ("en", "es", "ja", etc) as the CommandParameter and have that be defined for each "set language" button defined in the XAML. I want to avoid having to create a SetLanguageToXXX command for each language supporting and hard coding the two character language identifier into each RelayCommand in the ViewModel.

+1  A: 

You'll pass the param in the lambda to the command like so:

if (_aCommandWithAParameter == null)
{           
    _aCommandWithAParameter = new RelayCommand(               
        param => this.CommandWithAParameter(param)
        );        
}
Paul Alexander
Paul,I get the Compiler Error "Invalid expression ')'" when I use the syntax you suggest above.
eesh
the ** characters are to show emphasis - they should not be in the code you actually cut and paste.
Paul Alexander
Paul thanks you are right. I should have realized the ** on either side were for emphasis. Your solution works. I marked Kent's solution as the answer because it is simpler (or should I say easier to understand without the lambda expressions).
eesh
Would you mind editing your answer to show = new RelayCommand(param => this.CommandWithAParameter(param)). I think that will be easier for others to understand and they won't make the same cut and paste mistake I made. I am guessing I don't have enough reputation points to edit other's answers yet otherwise I would do it myself.
eesh
+3  A: 

I don't understand why you have the extra complexity of specifying the lambda in the first place. Why not just do this:

if (_aCommandWithAParameter == null)
{           
    _aCommandWithAParameter = new RelayCommand(CommandWithAParameter);
}

private void CommandWithAParameter(object state)
{
    var str = state as string;
}

HTH, Kent

Kent Boogaart
readonly Action<object> _execute; readonly Predicate<object> _canExecute; public RelayCommand(Action<object> execute) : this(execute, null) { } public RelayCommand(Action<object> execute, Predicate<object> canExecute) { if (execute == null) throw new ArgumentNullException("execute"); _execute = execute; _canExecute = canExecute; }Action<object> is a delegate and requires a lambda expression when calling the constructor. Not sure why, but I get a compiler error otherwise.
eesh
Because it's Action<object>, not Action<string>. Updated my post to clarify.
Kent Boogaart
Sorry about spacing in first comment. In any case the point is that the lambda expression is required because of the parameter argument in the RelayCommand constructor. Namely public RelayCommand(Action<object> execute) : this(execute, null). Since the constructor of RelayCommand takes a delegate, then when creating a new RelayCommand the lambda expression as shown in my post must be used. The parameter type in the method that is used on the right hand side of the lambda expression does alter the fact that a lambda expression must be used when creating a RelayCommand.
eesh
eesh, I don't follow. My code in my post compiles fine. There is no need for the lambda expression.
Kent Boogaart
You are correct Kent. Thank you for your answer. I marked your solution as the answer because it is simpler than Paul's solution which is also correct. I think I made the mistake of misremembering trying something similar to what you suggested but I included the parens after CommandWithAParameter in the argument to the constructor. I had the same thought as you "Why complicate this with lambda expression" but assumed the original author put it there because it was required. After your comment again I tried your solution verbatim and it worked of course.
eesh
Don't you have to use a lambda expression if there is no parameter? It won't compile for me otherwise.
JP
A: 

Can I receive the CommandParameter in the CanExecute-method?

A: 

I cannot substitute a reference to the method name for the lamda expression withing a compile error. Apparently, and by no means surprisingly, a non-static method name reference cannot be used in place of a lambda. I hardly see it as "added complexity". Consistently passing lamdas makes sense to me.

Rick O'Shea