views:

1124

answers:

4

The Entity Framework context object implements a Dispose() method which "Releases the resources used by the object context". What does it do really? Could it be a bad thing to always put it into a using {} statement? I've seen it being used both with and without the using statement.

I'm specifically going to use the EF context from within a WCF service method, create the context, do some linq and return the answer.

EDIT: Seems that I'm not the only one wondering about this. Another question is what's really happening inside the Dispose() method. Some say it closes connections, and some articles says not. What's the deal?

+1  A: 

Always, if you instantiate a class that implements IDisposable, then you are responsible for calling Dispose on it. In all but one case, this means a using block.

John Saunders
True, but the question is what the Dispose() method relly does for the EF context. It seems that it's not really _that_ important from what I can find on the topic!
Johan Danforth
"Responsible"... Isn't that for unmanaged code only?
ullmark
Thanks for asking this question. As a result, I found that all the Dispose calls that I'm worried about forgetting in our application might not be as critical as I feared (by reading http://lee.hdgreetings.com/2008/06/linq-datacontex.html).
BlueMonkMN
The article is about LINQ to SQL and I am not sure if the Entity Framework does not keep an open connection.
Daniel Brückner
... that said, I'll still probably return code for more work during my reviews if I see a DataContext being used that I can determine is not being disposed of properly. I think it's cleaner to dispose of all disposable objects if you can remember to do so.
BlueMonkMN
Although I'm using a DataContext, I assume EF also tracks object changes which is probably the larger resource in both cases.
BlueMonkMN
Since you won't know when Microsoft will change DataContext so that there's something to Dispose that you actually _care_ about, I suggest always disposing. The fact that a class has implemented IDisposable implies that it wants you to call Dispose. Be a good developer and do what the nice class asked you to do, ok? ;-)
John Saunders
I just had a quick look at the DataContext class and the cited article seems plain wrong - DataContext.Dispose() tries to close an underlying connection. (May be I am wrong and the connection is usually closed, but at least it tries to close it. And I cannot imagine that LINQ to SQL creates a new connection for every request because of the performance impact, so I tend to believe that the connection will be open while the data context is alive.)
Daniel Brückner
Well, I guess I could (and I do now, I'm a code reviewer myself), but the question is WHAT's happening in Dispose() really? Does it flush the edmx model from memory?
Johan Danforth
@Johan: it doesn't matter what it does today. It's not your code. It could change tomorrow. Given that you are depending on today's implementation, it probably _should_ change tomorrow, just to teach you why not!
John Saunders
@John: I agree.
Johan Danforth
+1  A: 

Since you don't know when the garbage collector disposes an item, it's always good to wrap up objects that implement IDisposable in a using-block if you know when you're done with it.

ullmark
+4  A: 

If you create a context, you must dispose it later. If you should use the using statement depends on the life time of the context.

  1. If you create the context in a method and use it only within this method, you should really use the using statement because it gives you the exception handling without any additional code.

  2. If you use the context for a longer period - that is the life time is not bound by the execution time of a method - you cannot use the using statement and you have to call Dispose() yourself and take care that you always call it.

What does Dispose()do for an object context?

I did not look at the code, but at least I exspect it to close the database connection with its underlying sockets or whatever resources the transport mechanism used.

Daniel Brückner
+1  A: 

When you dispose, the ObjectContext disposes other owned objects.

Including things like the EntityConnection which wraps the actual database connection, i.e. generally a SqlConnection.

So 'if' the SqlConnection is open it will be closed when you dispose the ObjectContext.

Alex James