views:

500

answers:

8

In Visual Studio when you add a new class, it always created with no modifiers and that makes class internal.

class MyClass
{
}

I would prefer that my class by default is created as public one.

Why is it internal by default?

What would you prefer?

+3  A: 

C# tends to default everything to the minimum scope necessary. This is a nice convention and quoted in Skeet's book (C# In Depth, p 224 "Note/Trivia"):

[Properties are the] only place where “private” is required—Everywhere else in C#, the default access modifier in any given situation is the most private one possible. In other words, if something can be declared to be private, then leaving out the access modifiers entirely will default it to being private. This is a nice element of language design, because it’s hard to get it wrong accidentally: if you want something to be more public than it is, you’ll notice when you try to use it.

Michael Haren
Actually, classes are internal by default. Class members are private.
Winston Smith
Try to create a class an look at with Reflector.
Vadim
Joe is correct. Classes *can't* be private (unless they're nested within other types), though their members by default are.
Noldorin
Yes, my mistake. Thanks for the explanation--a private class wouldn't make a lot of sense
Michael Haren
In C#, A class is Internal by default, unless it's a nested class
Costo
@Michael: Yeah, your updated answer is fine now. The minimum scope convention is a useful one to keep in mind.
Noldorin
+1  A: 

Because in C#, a class is internal by default. VisualStudio is therefore following the C# specification.

The following article explains access modifiers and default visibility in C#.

http://msdn.microsoft.com/en-us/library/ms173121.aspx

Winston Smith
A: 

Interestingly this only happens in C# - in vb.net you get a Public Class by default.

Personally, i prefer a public class by default as generally other classes need access to it. (most of my work is in the data layer though)

Pondidum
Do other classes outside your assembly really need access to most of your classes? I doubt it, but if so, you should reconsider how you group classes into assemblies! C# defaults to internal, where all classes in the same assembly have access.
Pontus Gagge
They do in the data layer...
Pondidum
+1  A: 

You could change the templates for a C# class - Usually located in "C:\Program Files (x86)\Microsoft Visual Studio 9.0\VC#"

or even create your own template.

TWith2Sugars
sarnath'd - personally I like to be prompted with an actual keyword, but 99% of the time my classes are public anyway. Hmm, maybe that's a design smell...
annakata
+5  A: 

If you want to modify the default behavior, check out this question/answer...

http://stackoverflow.com/questions/700086/how-do-you-default-a-new-class-to-public-when-creating-it-in-visual-studio

Steve Dignan
But be consciously aware of the potential implications of this...
BenAlabaster
+5  A: 

Making class internal by default makes perfect sense to me: keep your privates to yourself and only explicitly expose parts which really need to be exposed: everything else is just implementation details and should not be visible to the outside world.

In case you want to test your internal classes, .NET 2.0 onwards introduces a new attribute called InternalsVisibleToAttribute, which

Specifies that types that are ordinarily visible only within the current assembly are visible to another assembly.

If this really annoys you, see %ProgramFiles%\Microsoft Visual Studio 8\Common7 IDE\ItemTemplates\CSharp\1033\Class.zip. This is a template which you can change to suit your needs. ReSharper has similar capability, but it's directly accessible from within th UI.

Anton Gogolev
ReSharper by default creates public class. And that makes perfect sense to me.
Vadim
You can use InternalsVisbleToAttribute only with strong-signed assemblies.
Vadim
@Vadim: You're wrong.
Anton Gogolev
Anton, can you be more specific. It's not going to be the first time I'm wrong. I just want to know what I'm wrong about.
Vadim
Sorry, was in a hurry. See this page (http://msdn.microsoft.com/en-us/library/0tke9fxk.aspx ) for more info on this attribute.
Anton Gogolev
The path is slightly different for VS 2010, it is in "Common7\IDE\ItemTemplates\CSharp\Code\1033" (notice additional Code folder). Also it probably makes sense to modify the Interface template in the same folder.
Yacoder
+1  A: 

I prefer it the way it is. This way you have to consciously decide that you want it exposed to public. It's much like the argument, do you want your computer open to the outside world by default or would you rather configure it for internet access yourself.

Both approaches have their advantages, one has major potential security implications that I believe you should be aware of and make a conscious decision about rather than just it just happening automatically.

BenAlabaster
Good argument, in my opinion. Opt-in public exposure is preferable over opt-out.
Noldorin
+1  A: 

Personally I prefer it as is, It forces you to actively think which classes you want to make public.

It ultimately defaults you into a hopefully cleaner API design and hence better more friendly software. You wouldn't want to expose the inner workings of your code, which would inevitably happen if everything defaulted to public.

This is somewhat subjective, personally I prefer everything to off and turn on only what I need not the other way round.

danswain