Executing commands containing space in bash

Question

I have a file named cmd that contains a list of unix commands as follows:

hostname
pwd
ls  /tmp
cat /etc/hostname
ls -la
ps -ef | grep java
cat cmd

I have another script that executes the commands in cmd as:

IFS=$'\n'
clear
for cmds in `cat cmd`
do
        if [  $cmds ] ; then
     $cmds;
     echo "****************************";
        fi
done

The problem is that commands in cmd without spaces run fine, but those with spaces are not correctly interpreted by the script. Following is the output:

patrick-laptop
****************************
/home/patrick/bashFiles
****************************
./prog.sh: line 6: ls  /tmp: No such file or directory
****************************
./prog.sh: line 6: cat /etc/hostname: No such file or directory
****************************
./prog.sh: line 6: ls -la: command not found
****************************
./prog.sh: line 6: ps -ef | grep java: command not found
****************************
./prog.sh: line 6: cat cmd: command not found
****************************

What am I missing here?

Answer 1

EDIT: The comment by Ben Blank pointed out that my old answer was wrong, thanks.

Looks like you're executing commands as a single string, so bash sees them as the script/executable name.

One way to avoid that would be to invoke bash on the command. Change:

    if [  $cmds ] ; then
    $cmds;
    echo "****************************";
    fi

to

    if [  $cmds ] ; then
    bash -c $cmds
    echo "****************************";
    fi

Answer 2

Edit: Turns out this fails on pipes and redirection. Thanks, Andomar.

You need to change IFS back inside the loop so that bash knows where to split the arguments:

IFS=$'\n'
clear
for cmds in `cat cmd`
do
    if [ $cmds ] ; then
        IFS=$' \t\n' # the default
        $cmds;
        echo "****************************";
        IFS=$'\n'
    fi
done

Answer 3

Try changing the one line to "eval $cmds" rather than just "$cmds"

Answer 4

You can replace your script with the command

sh cmd

The shell’s job is to read commands and run them! If you want output/progress indicators, run the shell in verbose mode

sh -v cmd

Answer 5

I personally like this approach better - I don't want to munge the IFS if I don't have to do so. You do need to use an eval if you are going to use pipes in your commands. The pipe needs to be processed by the shell not the command. I believe the shell parses out pipes before the expanding strings.

Note that if your cmd file contains commands that take input there will be an issue. (But you can always create a new fd for the read command to read from.)

clear
while read cmds 
do
        if [ -n "$cmds" ] ; then
        eval $cmds
        echo "****************************";
        fi
done < cmd

Answer 6

sed 'aecho "-----------"' cmd > cmd.sh; bash cmd.sh

sed 'aXX' appends XX to every line. This will not work for multiline-commands like:

for f in * 
do 
    something $f
fi

but for single-line commands in most cases, it should do.