Get list of titles from xml files...

Question

Hello, I am trying to get titles of xml files from a folder call "bugs".

My code:

    public virtual List<IBug> FillBugs()
    {
        string folder = xmlStorageLocation + "bugs" + Path.DirectorySeparatorChar;

        List<IBug> bugs = new List<IBug>();

        foreach (string file in Directory.GetFiles(folder, "*.xml", SearchOption.TopDirectoryOnly))
        {
            var q = from b in bugs
                    select new IBug
                    {
                        Title = b.Title,
                        Id = b.Id,
                    };

            return q.ToList();
        }

        return bugs;
    }

But I'm not geting out the titles from all the xml files in the folder "bugs".

Answer 1

Do you need a backslash (Path.DirectorySeparatorChar) between xmlStorageLocation and "bugs"?

Answer 2

"from b in bugs" selects from an empty list. you need to initialize bugs from the file at the start of your foreach loop

Answer 3

Your code as written doesn't make any sense. Perhaps you meant something more like this:

public virtual List<IBug> FillBugs()
{
    // is this actually correct or did you mix up the concatenation order?
    // either way, I suggest Path.Combine() instead

    string folder = xmlStorageLocation + "bugs" + Path.DirectorySeparatorChar;

    List<IBug> bugs = new List<IBug>();

    foreach (string file in Directory.GetFiles(folder, "*.xml",
        SearchOption.TopDirectoryOnly))
    {
        // i guess IBug is not actually an interface even though it starts 
        // with "I" since you made one in your code

        bugs.Add(new IBug {
            Title = file, Id = 0 /* don't know where you get an ID */ });
    }

    return bugs;
}

Answer 4

You don't use file in your loop anywhere - Is that correct or did you miss to push it into the collection?

Answer 5

I did some change i my code, and i think it should work better now, but i still have a problem. Where fileName is a xml file

public virtual IList<IBug> FillBugs()
        {

            string[] fileEntries = Directory.GetFiles(xmlStorageLocation + "bugs" + Path.DirectorySeparatorChar);
            foreach (string fileName in fileEntries)
            {
                XDocument XmlBug = XDocument.Load(System.Web.HttpContext.Current.Server.MapPath(fileName));

                var q = from b in XmlBug.Descendants("bug")
                        select new IBug
                        {
                            Title = b.Element("title").Value,
                            Id = b.Element("id").Value,
                        };

                return q.ToList();
            }

            return /// what should i return here?


        }

Answer 6

the biggest problem is to get eatch files to singel string and not string[].