Modify contents in foreach

Question

I tend to use ArrayLists of structures. It is then very easy to cycle through the list with a foreach.

The problem I have is I cant use a foreach to modify the structures contents and have to use a for and messy typecasts.

((dataStructure)files[x]).name = here;

Is there a tidier way to do it?

Answer 1

Yes, there is: don't use an untyped ArrayList, these types are deprecated in favour of the generic types in System.Collections.Generic. In your case: List<T>.

You still can't use it in conjunction with a foreach loop to modify structure values but at least you don't have to cast.

Answer 2

I know this sounds simplistic but just say no to mutable value types.

They're almost never the right solution to the problem. There are a very few exceptions, but classes are almost always the way to go.

In addition, if you're really using an ArrayList then you'll be incurring an unboxing cost already... (As Konrad says, if you can use .NET 2.0 then use generics.)

If you really insist on using mutable structures, then use a for loop instead of foreach. But please, please change to classes anyway.

Answer 3

Use the generic version of ArrayList: List<DataStructure>.

This way things look a lot better:

files[x].name = here;