Validating Xml with Xsd

Question

I'm running into real difficulties validating xml with xsd. I should prefix all of this and state up front, I'm new to xsd and validation, so I'm not sure if it's a code issue or an xml issue. I've been to xml api hell and back with the bajillion different options and think that I've found what would be the ideal strategy for validating xml with xsd. Note, my xml and xsd are coming from a database so I don't need to read anything from disk.

I've narrowed my problem down into a simple sample windows form app. It has a textbox for xsd (txtXsd), a textbox for xml (txtXml), a textbox for the result (txtResult), and a button to start the validation (btnValidate).

I'm using a sample xsd file from Microsoft.

<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns="urn:bookstore-schema" elementFormDefault="qualified" targetNamespace="urn:bookstore-schema">
 <xsd:element name="title" type="xsd:string" />
 <xsd:element name="comment" type="xsd:string" />
 <xsd:element name="author" type="authorName"/>
 <xsd:complexType name="authorName">
  <xsd:sequence>
   <xsd:element name="first-name" type="xsd:string" />
   <xsd:element name="last-name" type="xsd:string" />
  </xsd:sequence>
 </xsd:complexType>
</xsd:schema>

I'm using the following code in my app.

private void btnValidate_Click (object sender, EventArgs e)
{
 try
 {
  XmlTextReader reader = new XmlTextReader(txtXsd.Text, XmlNodeType.Document, new XmlParserContext(null, null, String.Empty, XmlSpace.None));
  XmlSchema schema = XmlSchema.Read(reader, null);
  XmlSchemaSet schemas = new XmlSchemaSet();
  schemas.Add(schema);

  XDocument doc = XDocument.Parse(txtXml.Text);
  doc.Validate(schemas, ValidateSchema);
 }
 catch (Exception exception)
 {
  txtResult.Text += exception.Message + Environment.NewLine;
 }
}

private void ValidateSchema (Object sender, ValidationEventArgs e)
{
 txtResult.Text += e.Message + Environment.NewLine;
}

As a test, I put in valid xml but what I think should not conform to the xsd above.

<xml>
 <bogusNode>blah</bogusNode>
</xml>

The result is nothing, no validation errors what soever. Any ideas?

Answer 1

Well, for one - your XSD defines a XML namespace xmlns="urn:bookstore-schema" which is not present in your XML test file - therefore, nothing in your XML test file will be validated.

If you remove those elements form your schema:

<xsd:schema xmlns:xsd="http://www.w3.org/2001/XMLSchema"&gt;
        <xsd:element name="title" type="xsd:string" />

then it will properly validate your XML test file and complain about the wrong elements.

Also using an element named <xml> might not be a great idea - since the directive <?xml ......?> is a pre-defined directive and should not appear as tag name elsewhere in your document.

Marc

Answer 2

You may also try XmlValidatingReader for XML validation

Answer 3

I don't want the user to submit xml that's not defined in the xsd.

Why do you care? Your schema validates the XML nodes that are in your namespace. Your processing logic processes the XML nodes that are in your namespace. Nodes that aren't in your namespace aren't relevant to either your schema or your logic.

If it's truly essential to restrict all nodes in the XML document to a specific namespace, you can accomplish that by extending the basic XmlReader validating logic found here.

    public static void Main()
    {
      const string myNamespaceURN = "urn:my-namespace";

      XmlSchemaSet sc = new XmlSchemaSet();
      sc.Add(myNamespaceURN, "mySchema.xsd");

      XmlReaderSettings settings = new XmlReaderSettings();
      settings.ValidationType = ValidationType.Schema;
      settings.Schemas = sc;
      settings.ValidationEventHandler += ValidationCallBack;

      XmlReader reader = XmlReader.Create("myDocument.xml", settings);

      while (reader.Read())
      {
          if ((reader.NodeType == XmlNodeType.Element ||
               reader.NodeType == XmlNodeType.Attribute)
              &&
              reader.NamespaceURI != myNamespaceURN)
          {
              LogError(reader.NamespaceURI + " is not a valid namespace.");
          }
      }
    }

    private static void ValidationCallBack(object sender, ValidationEventArgs e)
    {
        LogError(e.Message);
    }

    private static void LogError(string msg)
    {
        Console.WriteLine(msg);
    }