views:

195

answers:

2

I have a self hosted Net Tcp WCF service and I have the following method

        Subscribtion GetSubscribtion(int subscribtionId)
        {
            Subscribtion s;
            if (_subscribtionTable.TryGetValue(subscribtionId, out s) == false)
            {
                Console.WriteLine("Not Found SessionID");//for debugging
                throw new ArgumentException("Invalid Subscription Id");
            }
            return s;
        }

Is throwing exception is a good practice for reporting erros in service programming?

+2  A: 

In WCF you should instead be defining and throwing a FaultException. The following articles provide examples and details:

mundeep
+1  A: 

Since WCF inherently can be interoperable with non-.NET platforms, using Exceptions which is a strict .NET construct is a bad idea. It will also usually break your WCF connection, if you have one (e.g. in a session scenario).

The way to go is using interoperable SOAP faults that are transportable even to non-.NET clients.

Marc

marc_s
But this is net tcp service so I am sure all clients are .Net applications
Ahmed Said
Now - yes - what about tomorrow?
marc_s
And why start using the "wrong" approach, if you already know what the right approach is? You'll just end up running into problems sometime in the future.....
marc_s