I'm looking to formalize the way we do code reviews at within my department because at the moment it't a bit disorganised. Do you have a formal code review process? If so what is it and how do you think it could be improved? I'm working in a team of 5 developers which means there is not very much experience floating about the company i...
Do you peer review code before or after checking in to the repository? What do you see as the pros and cons of each option? ...
How much time do you spend doing peer code reviews? Do you review everything? I'm trying to push for more code reviews where I work at the moment and am trying to get a feel for what happens in the wider world. ...
Connection.close() may throw SqlException, but I have always assumed that it is safe to ignore any such exceptions (and I have never seen code that does not ignore them). Normally I would write: try{ connection.close(); }catch(Exception e) {} Or try{ connection.close(); }catch(Exception e) { logger.log(e.getMessag...
What is the relationship between Rietveld and Gerrit (Android's code review application)? ...
Java is nearing version 7. It occurs to me that there there must be plenty of textbooks and training manuals kicking around that teach methods based on older versions of Java; where the methods taught, would have far better solutions now. What are some boilerplate code situations, especially ones that you see people implement through fo...
I'm thinking of using PDO in all of my future webapp. Currently (using what I've learned from SO so far), what I have in my site to handle database connection is a Singleton class like this : class DB { private static $instance = NULL; private static $dsn = "mysql:host=localhost;dbname=mydatabase;"; private static $db_...
Generally, I like to keep an application completely ignorant of the IoC container. However I have ran into problems where I needed to access it. To abstract away the pain I use a basic Singleton. Before you run for the hills or pull out the shotgun, let me go over my solution. Basically, the IoC singleton does absolutly nothing, it s...
Is it a good practice to comment code that is removed? For example: // Code to do {task} was removed by Ajahn on 10/10/08 because {reason}. Someone in my developer group during a peer review made a note that we should comment the lines of code to be removed. I thought this was a terrible suggestion, since it clutters the code with us...
Here in Brazil we call it "Padrão de Codificação", probably in English this is called Coding Pattern or Code Style, a set of constraints to developers build their code following rules for naming variables, methods, classes, for instance. Another constraints can be written, not only for naming things. Our company has a coding pattern for...
Continuing my quest for enlightenment I was curious to see how others approach examining projects from an educational standpoint. How do you determine the quality of the code you are reviewing? How do you decide if a design/technique is worthy of adoption in your own development? ...
Hi, I am python newbie. Can ppl point towards good OSS for automated decent python code review tools. I am churning quite some python code these days. Want to pass it thru some quality tool. Thanks Related question: Are there any static analysis tools for Python? ...
I was just looking through my system and have a lot of old projects that have multiple backups and versions (yes I know, it's before I started using source control properly ;) ) The thing is, some of these apps are used everyday by my company and many may have a lot of code that may be useful to other projects. So I am wanting to go th...
What programming or naming conventions have you come across that really rub you the wrong way? For those that aren't aware, in C# we can wrap blocks of code with a #region directive, which allows you to collapse these blocks in Visual Studio for readability. So the convention on this team is to wrap all combinations of access modifi...
How are code reviews performed on your development team? I've been a developer for several years now in several different companies and I have noticed that there isn't a consistent approach to performing code reviews. At my current company, code reviews are non-existent, which has led to a significant decrease in the quality of the cod...
In an ongoing effort to improve my code I am looking for the best way to create and compare a salted password in .NET. Is there a better, or more secure, way of doing this? My current code is as follows: public static string CreateSaltedPassword(string salt, string password) { SHA1CryptoServiceProvider SHA1 = null; ...
Hi all, I am currently doing a little study over Sonar and (why not) other tools to manage code quality. I did not found the documentation much clear nor extended and I have some questions. Does somebody know and use it ? How can one integrate sonar into a complex project ? Can we manage a Perl or C project with Sonar & Maven 2? I wo...
I have been asked to present examples of code issues that were found during a code review. My audience is mostly non-technical and I want to try to express the issues in such a way that I convey the importance of "good code" versus "bad code". But as I review my presentation it seems to me I've glossed over the reasons why it is impor...
A friend of mine is studying Engineering in college. I've never studied / used C++ as I've always stuck to .NET and web based programming. When I heard her Intro. to Programming course was going to teach them the basics of C++ I decided to get her to send me notes / assignments each week so I would have some definite material to work fro...
Hi there, I've just inherited a web-based travel request system to support and maintain. I can - more or less - follow the logic of it all, but I can't figure out why certain design decisions were made and I was wondering if you could help out. I've already discovered "Unobtrusive Javascript" as a result of this for example, so it could ...