tags:

views:

897

answers:

7

hi all:

we are having this discussion in our team about code conventions for java for

interface: should it be Foo or IFoo or FooInterface

abstract: Foo or AbstractFoo or ?

Enums: Foo or FooEnum

I m basically trying to put my personal preferences aside :) so reasons to back up one or other convention are very welcome Cheers

+8  A: 

In Java: Foo, AbstractFoo and Foo - although AbstractFoo could just be Foo.

Evidence:

  • java.util.List (interface)
  • java.util.AbstractList (abstract class)
  • java.util.Formatter.BigDecimalLayoutForm (enum)

For the interface part, see the Naming Conventions section of the Java Coding Conventions document. It doesn't talk about enums and abstract classes though.

Jon Skeet
+1  A: 

My convention:

  • Interface: Foo;
  • Abstract: AbstractFoo;
  • Enum: usually Foo but in some circumstances FooType.

IFoo is very .Net, not Java. FooInterface I've never seen used.

cletus
IFoo is also used throughout the Eclipse codebase, which is very Java, but they could very well have picked it up from .NET.
Peter Dolberg
Although I pointed out that it's used in Eclipse, I'm not recommending it. In fact, I prefer Foo to IFoo.
Peter Dolberg
+2  A: 

My convention:

  • interface: Foo
  • abstract: it depends FooAdaptor or AbstractFoo or BaseFoo
  • enum: Foo or Foos

I really dislike using I in interface names or even FooInterface:

 interface FooInterface {

is like writing:

 class FooClass {

or even:

 abstract class AbstractFooClass {

it is simply prolix.

dfa
prolix ?
Here Be Wolves
verbose, tiresome, etc
dfa
Class names are generally supposed to be singular nouns. Thus, Foos probably isn't a good name for an enum, (although Foo is).
James
+6  A: 

interfaces: Foo

Reason: Your code must not need to know that they are dealing with an interface. Writing 'IFoo' does just that. Instead, Foo makes it clear that 'Foo' is generic, and the object behind it may be a 'NumFoo' or a 'StrFoo'. The code really need not care.

abstract classes: AbstractFoo

Reason: your code is never going to use this class directly. You will always subclass this class to make any classes that are used by other code. So it must be amply clear to a programmer that the class is an abstract one. And what better way to name it Abstract! Places where you need to use references of type AbstractFoo, you should reconsider using an interface instead. (Ofcourse, this is not possible in C++)

Enums: FooType or FooEnum. Personally, FooType is better because Type relates more easily to the "real world" that Enum does.

Cheers!

Here Be Wolves
+4  A: 

No special conventions.

Having special naming conventions for these kinds of classes is basically a form of Hungarian notation (the bad kind): the information it gives you is already present in the syntax and is usually made easily available by IDEs e.g. when you hover over the name. Putting it into the name itself is pointless and ugly.

Class names should simply describe the class's role as well as possible. This can lead to "natural" naming conventions - a very good example is the Java convention of naming interfaces with an -able suffix (Iterable, Comparable) - but I don't want to imagine the result if it were universally enforced and List, Map, etc. had to follow it.

Michael Borgwardt
but what if you have many close-by-functionality-classes?the conventions free you to not waste meaningful names. for Foo classes branch you just use IFoo, AbstractFoo, Foo, ExtendedFoo and happy, while without, what names will you choose? Foo, Foo2, Foo3, SuperFoo?
Imaskar
Not having conventions doesn't mean you're *not allowed* to name classes like that, only that you don't have to use such names everywhere. But in your example, I'd have Foo as the interface, AbstractFoo is necessary since interfaces and classes share the same namespace, but the concrete classes should have distinctive names that describes their concrete aspect.
Michael Borgwardt
An example from Java: Map is the interface, and then there's AbstractMap, HashMap, TreeMap, LinkedHashMap, etc...
Michael Borgwardt
A: 

About interfaces:

I prefer IFoo because it’s a talking name, telling you it is an inferface right away. Second, for modules etc. where you do an interface for just one class, the class often has the same name as the interface. Then you can use Foo extends IFoo. Otherwise, well, you’d have to find a name. Or use FooInterface or whatever …

java.util.list as stated uses Foo. This is no problem as classes with different concepts implement it, thus already suggesting a different name (ArrayList, LinkedList …). I’m not quite sure if I really would prefer IList there. Dunno … :P

Kissaki
A: 

Regarding the interfaces I personaly like:

Fooable
merxbj