views:

1924

answers:

4

Could any one suggest a tool for performing peer code review before check-ins that is integrated with Team Foundation Server and Visual Studio 2008?

[Update]: Looks like there is no such tool. Can you suggest the best process for code-review after check in?

+7  A: 

The key feature that help us do code reviews on our team would be shelvesets. Granted, they are a less visible feature to work with in Visual Studio Team Editions out of the box. You can take it a step further and define a workflow as part of your Team Project template that enforces the code review process through policies and custom work items. A good example to start from can be found in CodePlex: TFS Code Review Workflow

Personally, I have not used the workflow; our team feels that we are sufficiently able to perform code reviews with the base shelveset feature. It only takes a little understanding on how to use it. Here is a summary of our process:

  1. Developer creates a shelveset of the changes they want to commit.

  2. Developer sends an email to the Reviewer specifying the name of the shelveset to review and any associated work items to reference in the changes.

  3. Reviewer gets the shelveset and performs a review, optionally making any suggested modifications if necessary in a new shelveset.

  4. Reviewer sends an email to notify the Developer once the review has been completed.

  5. If the review did not result in any suggested modifications for the Developer to make, the shelveset can be committed by the Developer. Otherwise, modifications are made and the process repeats.

Saul Dolgin
klashar
If you feel that it is too time consuming to switch out of the IDE you might want to look into the Code Review Workflow on CodePlex. It makes use of event subscriptions to email the code review team when a new work item is created for them to review.
Saul Dolgin
Instead of copy/paste, why not have the reviewer shelve his changes?
Richard Berg
+5  A: 

There is another solution on Codeplex named Team Review thats is a pretty comprehensive peer reviewing system. It also makes use of shelved check ins, and event subscriptions to inform reviewers.

PaulG
This is a good solution for code review <b>after</b> check in. All work with shelves steal shall be processed by hand in case of code review after check in.
klashar
+1  A: 

www.codeplex.com/Malevich

A: 

Code Collaborator

Jeff Davis