ansaurus

Question

Why does FormsAuthentication.RedirectFromLoginPage() end with context.Response.Redirect(..., false)?

Answer 1

+3 A:

Setting "endResponse" to true means that the Response.Redirect() call also forces a call to Response.End().

Response.End() will immediately transfer the code execution over to Application_EndResponse event, and raises a ThreadAbortException at the end of everything.

Basically, it's a cleaner "shutdown" of the response if you leave the parameter as false. If you can structure the logic of your method to basically finish right after the the Response.Redirect() call, you can avoid all the weird things that happen with forcing a Response.End().

womp 2010-01-10 22:06:02

So in my Controller, after calling FormsAuthentication.RedirectFromLoginPage, I should call Response.End? Or return EmptyResult()?

ripper234 2010-01-10 22:22:08

(Given that I do have to return something from the action)

ripper234 2010-01-10 22:22:46

Return an EmptyResult [or a null ActionResult]. Calling Response.End() from within an action method will cause any result filters you have registered to be skipped.In a perfect world the action would return a RedirectFromLoginResult, and its ExecuteResult() override would contain a call to Response.Redirect(). In fact, the ASP.NET MVC 2 default AccountController template does just this.

Levi 2010-01-11 05:45:43

Edit to above comment: The RedirectFromLoginResult never actually made it into the MVC templates, sorry about the confusion. But in a perfect world it would be there. :)

Levi 2010-01-11 18:59:36

ansaurus

tags:

views:

answers:

Why does FormsAuthentication.RedirectFromLoginPage() end with context.Response.Redirect(..., false)?

related questions