ansaurus

Question

How to combine these two JavaScript functions?

Answer 1

A:

function combined(curtext, curimage){
  if(curtext == "View large image"){
      document.getElementById("boldStuff").innerHTML = "View small image";
        curtext="View small image"; 
      }
      else{
       document.getElementById("boldStuff").innerHTML= "View small image";
           curtext="View large image";    
  }
  if(curimage == "cottage_small.jpg"){
       document.getElementById("myImage").src="cottage_large.jpg";
       curimage="cottage_large.jpg";
        }
      else{
       document.getElementById("myImage").src="cottage_large.jpg";    
       curimage="cottage_small.jpg";
  }
}

gmcalab 2010-03-15 21:28:56

Answer 2

A:

Make a new function that calls them both, and rename them to something unique.

var changeCombined = function() {
    changeTxt();
    changeSrc();
};

function changeTxt() {
    var node = document.getElementById("boldStuff");

    if ( node.innerHTML == "View large image") {
        node.innerHTML = "View small image";
    } else {
        node.innerHTML = "View large image";
    }
}

function changeSrc() {
    var image = document.getElementById("myImage");

    if ( image.src == "cottage_small.jpg") { 
        image.src = "cottage_large.jpg";
    } else {
        image.src = "cottage_small.jpg";
    }
}

This also removes your dependency on globals.

Justin Johnson 2010-03-15 21:56:07

ansaurus

tags:

views:

answers:

How to combine these two JavaScript functions?

related questions