ansaurus

Question

C code won't compile

Answer 1

+4 A:

Break it down in to smaller parts until you know what part of it doesn't compile. When you've done that the answer is usually before your eyes.

idstam 2010-05-01 15:48:18

Answer 2

+6 A:

Its almost easier to tell you what is not wrong with the code that you posted. I strongly recommend that you stop right now, read the book described here, learn about loops and arrays and completely rewrite your code. Sorry to be a little harsh, but you did post it for review.

In the future, when asking questions on SO (especially if something does not compile), at least post the compiler errors and elaborate on what you do not understand. Your question, as-is basically says "Please copy this code, try to compile it and tell me what is wrong with it" .. which will draw an adverse reaction from other users.

Again, I strongly recommend getting a hold of the book, working through the exercises and then revisit your problem.

I have made this community wiki so that anyone with 100+ rep can recommend additional books and web resources. Please use this post to do so, feel free to edit it.

Additional Reading:

Learning GNU C, http://www.faqs.org/docs/learnc/
The GNU C Library Manual, http://www.gnu.org/s/libc/manual/

Tim Post 2010-05-01 15:55:04

I strongly recommend avoiding "Learn C in 5 hours" http://johnt.tripod.com/c.html

James Morris 2010-05-01 16:22:38

@James My eyes .. MY EYES .... Warning: Link is an _angry fruit salad_

Tim Post 2010-05-01 16:55:58

Excellent post Tinkertim :) t0mm13b.

tommieb75 2010-05-01 18:12:39

By the way I would recommend to read other SO postings with the tag C, and just ummm C how is it done and learn from other SO user's answers and explanations into the depths of C code for gotchas and other intricate details that can throw off anyone.

tommieb75 2010-05-01 18:16:11

Answer 3

+4 A:

In C function def cannot be nested and that is what you are doing:

int main(void){                      // start of main fun def.
    int i,k,x,y,run,e,r,s,m,count=0;

char numbers[19][19];
for(i=0;i<19;i++){
          for (k=0;k<19;k++){
                   numbers[i][k]='.';
          }                         // end of inner for loop.
}                                   // end of outer for loop.


void drawB(){  //<--------- main() not yet completed..you've a new fun def.

codaddict 2010-05-01 16:15:28

Not if the asker is using GNU C, which supports nested functions :-) I'm thinking the asker would be happier learning JavaScript, Python, or even Go (the programming language) first instead of C.

Joey Adams 2010-05-01 16:30:54

@Joey .. `system("pause");` is a very strong hint that the user is not using GNU C.

Tim Post 2010-05-01 17:13:41

@Tim Wrong. This is boilerplate that the DevC++ IDE inserts into its projects - DevC++ uses GCC as the compiler. This sort of thing is one of the many, many reasons why no-one should be using DevC++.

anon 2010-05-01 17:20:12

@Neil, that would explain the commented out C++. Hereby redacted (well, would be, if I could still edit it).

Tim Post 2010-05-01 17:44:51

Answer 4

+2 A:

This looks like the very very beginnings of an attempt at a program for Go (the board game, not the recent programming language.) Anyway, there are many issues with this code, but as far as failing to compile, I can see at least one. With much, much code deleted, you very roughly have this:

int main(void) {
    char numbers[19][19];
    /* stuff */
}
void drawB(void) {
    printf("...", ..., numbers[X][Y], ...);
}

Inside drawB, the code cannot see the declaration of numbers inside of main, so the compiler will be giving you some sort of error about an undeclared variable drawB. You need to move the declaration of numbers outside of main, so that both main, drawB, and all the other functions that reference numbers can see it.

@unicornaddict has pointed out that you've actually nested the defintion of drawB inside of main. Perhaps you meant to do this, or perhaps it's just impossible to tell because of the inconsistent indentation inside of main. Either way, once you fix the nesting problem, you'll have to move the declaration of numbers outside of your functions. So, your code should now look a bit like this:

char numbers[19][19];
int main(void) {
    /* stuff */
}
void drawB(void) {
    printf("...", ..., numbers[X][Y], ...);
}

Dale Hagglund 2010-05-01 16:18:33

ansaurus

tags:

views:

answers:

C code won't compile

related questions