ruby problems for methods

Question

I have the following code. I want to use the methods for myserver1 and myserver2 and pass them the addresses the have been iterated through in the send_to_servers method. I can't seem to do that. Please help. Unless I can have these two receive addresses on an altering basis, I won't be able to do what I need to do. Thanks in advance.

class Addresses
  def add
    @addresses = %w([email protected] [email protected] [email protected])
  end

  def myserver1
    puts "Sending email from myserver1 with address #{@address}"
  end

  def myserver2
    puts "Sending email from myserver2 with address #{@address}"
  end

  def servers
    serv = [myserver1, myserver2]
  end
  #  def servers
  #    serv = (1..2).to_a       # Your list of servers goes here
  #  end


  def send_to_servers(servers)
    @addresses.each.with_index do |address, i|
      server = servers[i % servers.length]
      puts "Sending address #{address} to server #{server}"
      @address = address
    end
  end

end


a = Addresses.new
a.add
servers = a.servers
a.send_to_servers(servers)

Answer 1

It's unclear how you might want to structure it, but here is a concise implementation that I think meets your description.

def myserver1(address)
  # Do something with address
end

def myserver2(address)
  # Do something with address
end

addresses = %w([email protected] [email protected] [email protected])
servers = %w(myserver1 myserver2).cycle
addresses.each do |address|
  send(servers.next, address)
end

Apologies if I'm missing something crucial to your problem with this. Please feel free to comment on what extra functionality is required to help firm up the specification.

Answer 2

Your problem is that your server methods do not return anything:

def myserver1
  puts "Sending email from myserver1 with address #{@address}"
end

This method prints the message out and returns nil. puts always returns nil.

Thus, when you do [myserver1, myserver2], it prints out two messages and returns [nil, nil].

Servers are things, they should probably be objects, not methods. Methods are actions that do and/or return something. Try something like this:

class Server
  def initialize(name)
    @name = name
  end

  def send_address(address)
    puts "Sending email from #{@name} with address #{address}"
  end
end

addresses = %w([email protected] [email protected] [email protected])
servers = [Server.new("server one"), Server.new("server two")]
addresses.each_with_index do |address, i|
  server = servers[i % servers.length]
  server.send_address(address)
end

Answer 3

I believe your code should be refactored to be closer to the real world.

You want to loop through a list of email addresses and send each iteration to myserver2 and myserver2.

This means you need to have the cartesian product of emails and servers and do "send" to that pair.

require 'net/smtp'

emails = %w{[email protected] [email protected]}
servers = %w{server1 server2}
emails.product(servers).each do |address, server|
  Net::SMTP.start(server) do |smtp|
    smtp.send_message 'Body', '[email protected]', [address]
  end
end