views:

3233

answers:

4

Say I have a Rails Model called Thing. Thing has a url attribute that can optionally be set to a URL somewhere on the Internet. In view code, I need logic that does the following:

<% if thing.url.blank? %>
<%= link_to('Text', thing_path(thing)) %>
<% else %>
<%= link_to('Text', thing.url) %>
<% end %>

This conditional logic in the view is ugly. Of course, I could build a helper function, which would change the view to this:

<%= thing_link('Text', thing) %>

That solves the verbosity problem, but I would really prefer having the functionality in the model itself. In which case, the view code would be:

<%= link_to('Text', thing.link) %>

This, obviously, would require a link method on the model. Here's what it would need to contain:

def link
  (self.url.blank?) ? thing_path(self) : self.url
end

To the point of the question, thing_path() is an undefined method inside Model code. I'm assuming it's possible to "pull in" some helper methods into the model, but how? And is there a real reason that routing only operates at the controller and view layers of the app? I can think of lots of cases where model code may need to deal with URLs (integrating with external systems, etc).

+7  A: 

Any logic having to do with what is displayed in the view should be delegated to a helper method, as methods in the model are strictly for handling data.

Here is what you could do:

# In the helper...

def link_to_thing(text, thing)
  (thing.url?) ? link_to(text, thing_path(thing)) : link_to(text, thing.url)
end

# In the view...

<%= link_to_think("text", @thing) %>
Josh
What I don't like about helper methods in this case: When I look at link_to_thing(), I have to decide whether that's a thing-specific or application-wide helper (it easily could be either). I need to consider checking 2 files for the source. thing.link leaves no question about the source file.
Aaron Longwell
Also, what if I need to use this functionality in a Rake task (to export a CSV file of thing URLs perhaps)... going directly to the model would be much better in that case as well.
Aaron Longwell
But the difference is that the link_to wouldn't be available in the model, since it is an ActionView helper. So, this would not work. You could hack some attribute defaults in the model, so if it isn't set, it defaults to something, but that's up to you.
Josh
With web services APIs growing, often times models need to contact external resources with their own data and provide callback URLs. For example, a photo object needs to post itself to Socialmod, which will call back to that photo's URL when moderation is performed. An after_create() hook would make sense to post to Socialmod, but how do you know the callback URL? I think the author's own answer makes good sense.
jhs
+1  A: 

While there might be a way I would tend to keep that kind of logic out of the Model. I agree that you shouldn't put that in the view (keep it skinny) but unless the model is returning a url as a piece of data to the controller, the routing stuff should be in the controller.

Ryan Montgomery
Re: "Unless the model is returning a URL as a piece of data". That's exactly what is happening here... the Model "owns" this piece of data, which is either a link to an on-site or off-site URL. In some cases the URL is generated from Rails Routing. In other cases, the URL is user-supplied data.
Aaron Longwell
A: 

(Edit: Forget my previous babble...)

Ok, there might be situations where you would go either to the model or to some other url... But I don't really think this belongs in the model, the view (or maybe the model) sounds more apropriate.

About the routes, as far as I know the routes is for the actions in controllers (wich usually "magically" uses a view), not directly to views. The controller should handle all requests, the view should present the results and the model should handle the data and serve it to the view or controller. I've heard a lot of people here talking about routes to models (to the point I'm allmost starting to beleave it), but as I understand it: routes goes to controllers. Of course a lot of controllers are controllers for one model and is often called <modelname>sController (e.g. "UsersController" is the controller of the model "User").

If you find yourself writing nasty amounts of logic in a view, try to move the logic somewhere more appropriate; request and internal communication logic probably belongs in the controller, data related logic may be placed in the model (but not display logic, which includes link tags etc.) and logic that is purely display related would be placed in a helper.

Stein G. Strindhaug
Say you have an Image model. If the Image has an associated outside URL with it, then point to that URL. Otherwise, point to the Image's show page to upload an image? Just an idea.
Josh
How about this less generic example:link_to "Full Size Image", image.linkThe link method in the model would either link to the on-site URL (image_path), or to, say, a Flickr URL if the user provided one and .url was set on the image.
Aaron Longwell
+13  A: 

I've found the answer regarding how to do this myself. Inside the model code, just put:

include ActionController::UrlWriter

This magically makes thing_path(self) return the URL for the current thing, or other_model_path(self.association_to_other_model) return some other URL.

Aaron Longwell