ansaurus

Question

opening new window in ie7 opens same target as base window but shows proper url in firefox

Answer 1

+1 A:

I think the main problem is that you declared currentloc as a local variable three times.

In JavaScript it's all about scope, and every time you declared currentloc with the key word var you were basically saying that "I want this variable to exist within this if (or else if) statement and not outside it." Later on when you used window.open and you passed in currentloc, you were actually instantiating a new global variable since all other instances of currentloc had been lost.

Global variables are automatically created when you don't declare them with var (I think technically they are global properties of the global object, but I'm not 100% on that). In any case, it is considered a best practice to explicitly declare your variables and limit them to the minimum scope needed for your application.

Here is your modified code. I hope it works (tested IE8 quirks mode, and Firefox)

<html>
<head>
    <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.3/jquery.min.js" ></script>
    <script>
    $(document).ready(function() {
        jQuery.noConflict();
        var apple = 'http://www.apple.com';
        var microsoft = 'http://www.microsoft.com';
        var currentloc; 

        jQuery('#loginform').submit(function() 
        {
            var pass = jQuery('#myinput').val();

            if (pass=='apple') 
            {
                currentloc=apple;
            } 
            else if (pass=='microsoft') 
            {
                currentloc=microsoft;
            }
            else 
            {
                currentloc ='http://www.mysite.com/sorry'; 
            }
            window.open(currentloc, 'formpopup', 'width=800,height=600,resizeable=1,scrollbars=1');
        });
    });
    </script>
</head>
<body>
    <form id="loginform"> 
        <input id="myinput" type="text" /> 
        <input name="submit" value="go" type="submit" />
    </form>
</body>
</html>

Brandon Boone 2010-10-19 02:24:02

thanks for the thorough explanation, i always get a little lost with the global local thing...

liz 2010-10-20 14:48:39

ansaurus

tags:

views:

answers:

opening new window in ie7 opens same target as base window but shows proper url in firefox

related questions