views:

1055

answers:

10

I have a rather complex page that dynamically builds user controls inside of a repeater. This repeater must be bound during the Init page event before ViewState is initialized or the dynamically created user controls will not retain their state.

This creates an interesting Catch-22 because the object I bind the repeater to needs to be created on initial page load, and then persisted in memory until the user opts to leave or save.

Because I cannot use ViewState to store this object, yet have it available during Init, I have been forced to store it in Session.

This also has issues, because I have to explicitly null the session value during non postbacks in order to emulate how ViewState works.

There has to be a better way to state management in this scenario. Any ideas?

Edit: Some good suggestions about using LoadViewState, but I'm still having issues with state not being restored when I do that.

Here is somewhat if the page structure

Page --> UserControl --> Repeater --> N amount of UserControls Dynamicly Created.

I put the overridden LoadViewState in the parent UserControl, as it is designed to be completely encapsulated and independent of the page it is on. I am wondering if that is where the problem is.

+1  A: 

This also has issues, because I have to explicitly null the session value during non postbacks in order to emulate how ViewState works.

Why do you have to explicitly null out the value (aside from memory management, etc)? Is it not an option to check Page.IsPostback, and either do something with the Session variable or not?

Greg Hurlman
+1  A: 

I have always recreated my dynamic controls in the LoadViewState event. You can store the number of controls needed to be created in the viewstate and then dynamically create that many of them using the LoadControl method inside the LoadViewState event. In this event you have access to the ViewState but it has not been restored to the controls on the page yet.

DancesWithBamboo
A: 

@DancesWithBamboo:

If I dynamically bind the controls there, will ASP.NET automatically handle their state? The problem with doing it in Page_Load is that viewstate is already loaded and it does not add the dynamic controls in the repeater. I would think it would do the same in LoadViewState?

FlySwat
Are you using databinding? I never use it with asp.net and it might change the playing field somewhat. But, the LoadViewState is the event that should be used for restoring dynamic controls at post-back time. PageLoad is definitely too late in the life cycle.
DancesWithBamboo
A: 

1) there's probably a way to get it to work... you just have to make sure to add your controls to the tree at the right moment. Too soon and you don't get ViewState. Too late and you don't get ViewState.

2) If you can't figure it out, maybe you can turn off viewstate for the hole page and then rely only on querystring for state changes? Any link that was previously a postback would be a link to another URL (or a postback-redirect).

This can really reduce the weight of the page and make it easier to avoid issues with ViewState.

Ben Scheirman
A: 

@Jonathan:

Yes, the runtime will populate the viewstate of the controls as long as you create the right number of them. The controls' viewstate will populate after this event.

DancesWithBamboo
A: 

Yes, the runtime will populate the viewstate of the controls as long as you create the right number of them. The controls' viewstate will populate after this event.

In what order is LoadViewState called? I added an overridden method signature and it does not seem to be stepping into it.

FlySwat
A: 
protected override void LoadViewState(object savedState)
{
   // Put your code here before base is called
   base.LoadViewState(savedState);
}

Is that what you meant? Or did you mean in what order are the controls processed? I think the answer to that is it quasi-random.

Also, why can't you load the objects you bind to before Page_Load? It's ok to call your business layer at any time during the page lifecycle if you have to, with the exception of pre-render and anything after.

Daniel Auger
A: 

I have to explicitly null the session value during non postbacks in order to emulate how ViewState works.

I'm still foggy as to why you can't store whatever object(s) you are binding against in session. If you could store that object in session the following should work:

  1. On first load bind your top user control to the object during OnPreInit. Store the object in session. Viewstate will automatically be stored for those controls. If you have to bind the control the first time on Page_Load that is ok, but you'll end up having two events that call bind if you follow the next step.
  2. On postback, rebind your top user user control in the OnPreInit method against the object you stored in session. All of your controls should be recreated before the viewstate load. Then when viewstate is restored, the values will be set to whatever is in viewstate. The only caveat here is that when you bind again on the postback, you have to make 100% sure that the same number of controls are created again. The key to using Repeaters, Gridviews etc... with dynamic controls inside of them is that they have to be rebound on every postback before the viewstate is loaded. OnPreInit is typically the best place to do this. There is no technical constraint in the framework that dictates that you must do all your work in Page_Load on the first load.

This should work. However, if you can't use session for some reason, then you'll have to take a slightly different approach such as storing whatever you are binding against in the database after you bind your control, then pulling it out of the database and rebinding again on every postback.

Am I missing some obvious detail about your situation? I know it can be very tricky to explain the subtleties of the situation without posting code.

EDIT: I changed all references to OnInit to OnPreInit in this solution. I forgot that MS introduced this new event in ASP.NET 2.0. According to their page lifecycle documentation, OnPreInit is where dynamic controls should be created/recreated.

Daniel Auger
A: 

When creating dynamic controls ... I only populate them on the initial load. Afterwords I recreate the controls on postback in the page load event, and the viewstate seems to handle the repopulating of the values with no problems.

mattruma
+3  A: 

The LoadViewState method on the page is definitely the answer. Here's the general idea:

protected override void LoadViewState( object savedState ) {
  var savedStateArray = (object[])savedState;

  // Get repeaterData from view state before the normal view state restoration occurs.
  repeaterData = savedStateArray[ 0 ];

  // Bind your repeater control to repeaterData here.

  // Instruct ASP.NET to perform the normal restoration of view state.
  // This will restore state to your dynamically created controls.
  base.LoadViewState( savedStateArray[ 1 ] );
}

SaveViewState needs to create the savedState array that we are using above:

protected override object SaveViewState() {
  var stateToSave = new List<object> { repeaterData, base.SaveViewState() };
  return stateToSave.ToArray();
}

Don't forget to also bind the repeater in Init or Load using code like this:

if( !IsPostBack ) {
  // Bind your repeater here.
}
William Gross