Switch statement and isset

Question

Since a couple of months ago my website was full of notice errors so I'm trying to fix the code now. I suppose there was some php update. I'm not so bright at php so:

switch ( (isset($_GET['action'])) ) {

case "delete":
delete();
break;

}

this won't work when I add isset.

Can't you use isset inside a function? I dont know really so I'm asking you guys that know these things.

cheers

Answer 1

That is because isset returns true or false, not a string (which is what your case statements expect).

Answer 2

isset() returns bool (true or false). You want to call isset() before switch. Example:

if (isset($_GET['action']))
{
  switch($_GET['action'])
  {
    ...
  }
}

Answer 3

You need to check isset() before you go into the switch.

Answer 4

isset returns a bool (see the isset manual page). Your case won't work, as 'deleted' is not a valid boolean value (it evaluates to true I think, but still).

You should check if it's set first, then switch:

if(isset($_GET['action')) {
  switch ( $_GET['action']) ) {
    case "delete":
      delete();
      break;
  }
} else {
  ...
}